Modify

Opened 8 years ago

Closed 3 years ago

#615 closed defect (wontfix)

javascript failed in Internet Explorer

Reported by: shuoshuo+trac@… Owned by: coderanger
Priority: normal Component: CtxtnavAddPlugin
Severity: critical Keywords:
Cc: Trac Release: 0.10

Description

  1. Background
  1. Fix
    • ctxtnavadd.js
                          if(li_node.getAttribute('class') == 'last'
                              || li_node.getAttribute('className') == 'last') {
                              return(li_node);
                          }
      

Attachments (1)

ctxtnavadd.js (1.1 KB) - added by kennethxu 7 years ago.
fixed IE problem.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by dgynn

I can verify this fix solves the problem in IE. You also need to make a similar change to the code that resets the 'last' item's class.

     new_li.setAttribute('class','last');
     old_li.removeAttribute('class');
+    new_li.setAttribute('className','last');
+    old_li.removeAttribute('className');

comment:2 Changed 8 years ago by jason_field

I think there is a neater way to do it,

In find_old_last() instead of the getAttribute call;

if( li_node.className == 'last' ) {

and in add_ctxtnav() instead of the setAttribute call;

new_li.className = 'last'; old_li.className = ;

These changes seem to work on both IE and Firefox for me, and don't require doing essentially the same thing twice :)

comment:3 Changed 8 years ago by coderanger

I've totally rework the JavaScript in the 0.11 version using jQuery. I don't really intend to backport these changes (as I am currently very lacking of free time), but if someone wants to make a backport patch, I'll take a look.

Changed 7 years ago by kennethxu

fixed IE problem.

comment:4 Changed 7 years ago by kennethxu

I fixed this IE problem before I come to this ticket. file attached attachment:ctxtnavadd.js

Can somebody help to check into 0.10 branch?

comment:5 Changed 3 years ago by rjollos

  • Resolution set to wontfix
  • Status changed from new to closed

Plugin is deprecated.

Add Comment

Modify Ticket

Action
as closed The owner will remain coderanger.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.