Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6157 closed defect (invalid)

WebAdmin panel layout is not as nice on my system as shown in example

Reported by: rjollos Owned by: izzy
Priority: normal Component: LogViewerPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Hello,

I installed your plugin and it is working great. One minor issue is that the Selection box layout is not quite as nice on my system. Any idea of why that would be?

LogViewer Web Admin panel screen capture

Attachments (6)

LogViewer.png (160.6 KB) - added by rjollos 5 years ago.
LogViewer Web Admin panel screen capture
LogViewerPlugin-0.2dev_r7043-py2.5.egg (9.1 KB) - added by izzy 5 years ago.
Version with modified template
LogViewerEdit.png (118.0 KB) - added by anonymous 5 years ago.
LogViewerNoTheme.png (25.1 KB) - added by rjollos 5 years ago.
Screen capture of LogViewer with ThemeEnginePlugin disabled.
LogViewerPlugin-0.2dev_r7067-py2.5.egg (9.4 KB) - added by izzy 5 years ago.
Python egg to try with comment:17
LogViewerPlugin2009-11-17.png (274.2 KB) - added by rjollos 5 years ago.
Large screen capture on 2009-11-17

Download all attachments as: .zip

Change History (31)

Changed 5 years ago by rjollos

LogViewer Web Admin panel screen capture

comment:1 follow-up: Changed 5 years ago by izzy

Looks like an issue with CSS processing. What browser you are using? Which version of Trac? Are there any entries in your trac.log indicating trouble?

My guess is, bottom up: No entries, Trac 0.11+ - and: not Firefox, certainly...

comment:2 follow-up: Changed 5 years ago by izzy

P.S.: Do you have the IniAdminPlugin installed? If so, you should have the same problems there - since that's where I took the styling from, basically...

comment:3 in reply to: ↑ 1 Changed 5 years ago by anonymous

Replying to izzy:

Looks like an issue with CSS processing. What browser you are using? Which version of Trac? Are there any entries in your trac.log indicating trouble?

My guess is, bottom up: No entries, Trac 0.11+ - and: not Firefox, certainly...

  1. No entries in log file
  2. 0.11.4
  3. Firefox 3.5.4

I can also confirm it looks pretty much the same on IE8, Opera 10.01, Safari 4.0.3, Chrome 3.0. All from Vista x64.

Could it be related to the custom theme I'm using: GamedevTheme?

comment:4 in reply to: ↑ 2 Changed 5 years ago by anonymous

Replying to izzy:

P.S.: Do you have the IniAdminPlugin installed? If so, you should have the same problems there - since that's where I took the styling from, basically...

I do have the IniAdminPlugin installed. The layout looks okay for all panels of that plugin.

However, it looks like you have 'title boxes within title boxes' (that's a non-technical description). That is, there is a Log Level box within the Selection box. The IniAdminPlugin doesn't have a page with a layout like this, as far as I can see.

comment:5 Changed 5 years ago by izzy

Strange. I tested it using FF3.0.x on Linux, and FF3.5.x on Windows XP, and it looked OK. I will check on XP again tomorrow (at home I have MS-free zone) - I'm not sure if my last check there was before I encapsulated the fieldsets inside fieldsets. If that's the cause (I wonder why that should behave differently with the same browser just on different systems), it shouldn't be a big deal to fix.

To save time: If it's not too big a deal, could you try with the default theme of FF? I don't have any themes running here, so - even if unlikely - that could have influence, one never knows.

comment:6 follow-up: Changed 5 years ago by izzy

One more suggestion: If you have the Firebug addon installed in your Firefox, please try the following:

Look for <fieldset id="selection"> in the page source, and replace it by

<div id="selection" style="border:1px solid lightgray; height:80px;">

Then let me know how that looks. If you do not have that addon running: Please export the page to HTML, edit that HTML file as described above, and load it into FF again. After that, we know if the nesting of fieldsets is the cause of your issue.

Btw: Thanx to your hint not having this issue with IniAdminPlugin, I'm optimistic this is a possible solution. Of course, in that case the "legend" displayed ("Selection") would be removed in the final fix.

Changed 5 years ago by izzy

Version with modified template

comment:7 Changed 5 years ago by izzy

  • Status changed from new to assigned

Just in case you cannot do either of the manipulations: I attached you an egg using a modified template (with the changes described above) you can use to verify. I replaced the outer fieldset by a div. Please let me know whether this solves your issue.

comment:8 in reply to: ↑ 6 Changed 5 years ago by rjollos

Replying to izzy:

One more suggestion: If you have the Firebug addon installed in your Firefox, please try the following:

I do have Firebug installed. After the edit, the form looks like:


Changed 5 years ago by anonymous

comment:9 follow-up: Changed 5 years ago by izzy

OK, thanx for trying - this obviously does not help. Which leaves us with two things: I will test again under Windows tomorrow - and you might try if the theme has to do with it. You also might further play with Firebug, some suggestions:

  • set style='list-style-type:none' for the UL (to get rid of the dots)
  • look for the LI and check what property for float is applied (if "none", it is for sure one of the things below - which I suspect)

My current guess is some (local) style takes over. If you have the Stylish addon running, try to temporarily switch all styles off. Same for Greasemonkey (temporarily disable it). Other things that modify styles, as well. If it looks OK at one of these 3 steps, encircle it closer (e.g. switch back on one style after the other, until you found the troublemaker). If you was able to locate the issue this way, let me know: which Stylish file (either URL on userstyles, or attach it), or which GM script, etc. If it is some style collision (which IMHO is most likely), we can easily work around that.

comment:10 follow-up: Changed 5 years ago by rjollos

Hello,

Thank you for all of your help. I will try more of your suggestions and get back to you shortly.

Two more things:

  1. There is no coloring of the log levels on my site.
  2. The Logging tab in WebAdmin seems to have disappeared. You can see it is still present when I took the first screen capture, and has disappeared by the time I took the second screen capture.

There are some errors in my log file, but they seem to be associated with the FineGrainedPageAuthzEditorPlugin, as best I can tell. That plugin has been working fine. I did open ticket #6158 to see if the plugin author has any insight about that error.

SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
2009-11-04 12:34:34,265 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 435, in _dispatch_request
dispatcher.dispatch(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 205, in dispatch
resp = chosen_handler.process_request(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/chrome.py", line 379, in process_request
for dir in [os.path.normpath(dir[1]) for dir
AttributeError: 'PageAuthzPolicyEditor' object has no attribute 'get_htdocs_dirs'
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
2009-11-04 12:34:39,691 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 435, in _dispatch_request
dispatcher.dispatch(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 205, in dispatch
resp = chosen_handler.process_request(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/chrome.py", line 379, in process_request
for dir in [os.path.normpath(dir[1]) for dir
AttributeError: 'PageAuthzPolicyEditor' object has no attribute 'get_htdocs_dirs'
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
2009-11-04 12:34:51,068 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 435, in _dispatch_request
dispatcher.dispatch(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/main.py", line 205, in dispatch
resp = chosen_handler.process_request(req)
File "/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg/trac/web/chrome.py", line 379, in process_request
for dir in [os.path.normpath(dir[1]) for dir
AttributeError: 'PageAuthzPolicyEditor' object has no attribute 'get_htdocs_dirs'
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',)
SELECT value FROM system WHERE name=%s
('TracFormDBComponent:version',) 

comment:11 Changed 5 years ago by rjollos

One of the slightly challenging issues is that my Trac instance is with a hosting provider and I don't have root access. So, I've asked them if it is possible to allow me to switch between the default and Gamedev theme using ThemeEnginePlugin. Currently, the only option I have in WebAdmin is to select the Gamedev theme.

Another option would be to install first the LogViewerPlugin, and then the Gamedev theme, in my local Trac instance that I use for testing. That will take me slightly longer, so I might not be able to tackle it until the weekend.

comment:12 in reply to: ↑ 10 Changed 5 years ago by anonymous

Replying to rjollos:

  1. The Logging tab in WebAdmin seems to have disappeared. You can see it is still present when I took the first screen capture, and has disappeared by the time I took the second screen capture.

Never-mind about this item. I checked with my hosting provider and it turns out they disabled it after I brought to there attention that it was enabled; which is apparently a security risk in their shared hosting environment.

comment:13 follow-up: Changed 5 years ago by izzy

Confirmed the log message not being related, as far as I can tell. Strange that your log messages don't use colors - which again makes it even more likely being some style-override issue.

You didn't answer my question about the Stylish addon. If you have that, here's another suggestion - if not, the same could possibly hacked directly into the page with Firebug: Create a new style like this, just temporarily while the LogViewerPlugin page is loaded, and use the Preview button to check:

#log_form #selection #li_levels, #log_form #selection #li_search, #log_form #selection #li_tail {
  display:inline !important;
  float:left !important
}

This is just for the ordering of the elements, using a more explicit naming than the provided stylesheet (to make it less likely to be overridden) plus the !important attribute to enforce it even a bit more. Let me know whether that helped.

comment:14 follow-up: Changed 5 years ago by izzy

I just checked with FF 3.5.3 on XP, and everything looks fine. I also checked the sources of the GamedevTheme, and don't think this could be an issue. Furthermore, I neither expect any other Trac plugin to cause that issue - but if above steps don't give us a clue, it might be worth to check which ones you have installed. But since plugins are only loaded when their hook was called, their CSS wouldn't be applied in other cases - so I think that is very unlikely a part of the issue. As it looks to me now, best candidates are some Stylish CSS or GM scripts applying CSS. Modified versions of UserChrome.css or, more likely, UserContent.css in your FF profiles chrome/ directory, fall into the very same category.

The easiest way to exclude all of those would be to create a fresh profile using FFs profile manager, and check the page using that virgin profile. Since you are using Windows, you could also try the page with IE (results would be interesting for me as well, please include the version of IE used. I tried here at work with IE6 (nothing newer available), which has problems quite similar to the ones you reported: it doesn't show the dots, but moves the entire block below the left-hand navigation bar, plus additionally resizes it in width by always page width plus about 50px, so it never fits in. M$ crap. I don't care about such old versions, but for newer ones I would be interested in the results).

comment:15 in reply to: ↑ 14 Changed 5 years ago by rjollos

Replying to izzy:

I just checked with FF 3.5.3 on XP, and everything looks fine. I also checked the sources of the GamedevTheme, and don't think this could be an issue.

It looks like you are correct. I disabled the ThemeEnginePlugin, and now I see the following:

Screen capture of !LogViewer with ThemeEnginePlugin disabled.

Thank you for all of your time and work on this problem. I will look into your other questions and report back in a few hours.

Changed 5 years ago by rjollos

Screen capture of LogViewer with ThemeEnginePlugin disabled.

comment:16 in reply to: ↑ 13 Changed 5 years ago by rjollos

Replying to izzy:

Confirmed the log message not being related, as far as I can tell. Strange that your log messages don't use colors - which again makes it even more likely being some style-override issue.

Also, I still do not have log message coloring after uninstalling the GamedevTheme.

comment:17 Changed 5 years ago by izzy

That's what I expected from inspecting GamedevTheme code (the theme is not related). Which leaves us with the other stuff:

  • Try starting FF in safebrowsing mode (the easiest way to see if any addons are the cause, since none of them will be loaded then). Should look fine then. If so:
  • Try a "virgin" profile (should still look fine). Add your plugins one by one. When it looks screwed up again, you've found the candidate. If it still looks fine:
  • Styles and GM scripts, if any - again, one by one.

This way you should find out.

  • Let me know what it was.
  • Try the style modifications I've send you and see if they solve the issue (if you have no way doing so, let me know to support you with a modified egg again). If so, I will include that with the LogViewerPlugin for the future.

As for the colors, the same thing applies: As soon as we know the troublemaker, we can see how to get around that. As those elements have quite specific names (div.log_crit, div_log_err, div.log_warn, div.log_info, div.log_debug, div.log_other - oops, a typo in the style sheet: must be div.log_err), it is a very strange thing another style sheet should override these. Still, noone else reported a similar issue yet (well, the plugin is still young), so we have nothing to compare - and I still consider this an issue specific to your setup until proven otherwise (you know, this doesn't mean I won't get it fixed if I can).

Besides, you may want to try the always latest code (at least until we got the issue solved), to make sure we both check with the same code. If I applied changes, you see this in the "Recent changes" section of the LogViewerPlugin page.

comment:18 in reply to: ↑ 9 Changed 5 years ago by rjollos

Replying to izzy:

If you have the Stylish addon running, try to temporarily switch all styles off. Same for Greasemonkey (temporarily disable it).

I don't have either the Stylish addon or Greasemonkey installed. Since I see the issue with multiple browsers, it seems unlikely that the issue is related to a plugin installed under Firefox.

After disabling the ThemeEnginePlugin I tested again with the set of browsers I listed previously, and I see pretty much the same layout for all browsers.

I will try your html edits under Firebug, and also test from some other computers in my office (running XP Pro and Mac OSX 10.5).

Changed 5 years ago by izzy

Python egg to try with comment:17

comment:19 Changed 5 years ago by izzy

OK - I did not have that information. So it must be something inside Trac - which makes it harder to figure out. I just attached you a Python egg including the style modifications mentioned in comment:13 - please take a look whether this works.

I probably cannot ask you to temporarily disable all plugins but LogViewerPlugin. Could you send me a list of plugins you are using in your Trac installation, as well as mention modifications to the Genshi stuff (site styles etc)? The IniAdminPlugin we already can count out, I have it running as well. Same for the accountmanager.

Another thing worth a try: Is your Trac installation publically accessible - I mean, can I reach it with my browser via the internet? If so: Could you send me a link to it, so I temporarily register, and you grant me TRAC_ADMIN privileges (just temporarily - I promise to do nothing harmful, and you can remove that account later on), so I could see for myself? That would be the easiest way. If the cause lies in your Trac installation, I should see the same mess - and can try to figure out without all the ping-pong by tickets ;)

comment:20 Changed 5 years ago by rjollos

Hi izzy, thank you for all of your help. I'll be able to resume working on this bug later this evening. Had to deal with some other work the past few days.

comment:21 Changed 5 years ago by izzy

Thanx for the update - I already thought it might have been solved and you forgot to tell :) As said, the best thing would be I could take a look at it on your installation directly (see the last paragraph in comment:19). If you for some reason don't want to post the URL here, you find my mail address in the source of setup.py ;)

comment:22 Changed 5 years ago by rjollos

I haven't been able to get back to you as quickly as I would have liked, but I think we may have a resolution on this. The resolution came in a round-about way.

What happened was, after I upgraded the FullBlogPlugin to the latest version, the [[BlogList]] macro sidebar on the mainpage was not displayed correctly. Ticket #5736, though not reported by me, has a screen capture that shows exactly what I was seeing.

The prior week, I had noticed an error in the Trac log associated with the FineGrainedPageAuthzEditorPlugin, but I hadn't observed any incorrect behavior associated with the error. I had reported this error in #6158.

The admin at my hosting provider determined that problem with the FineGrainedPageAuthzEditorPlugin causing the error in #6158 was also causing the error with the FullBlogPlugin described by #5736.

After he fixed the issue with the FineGrainedPageAuthzEditorPlugin, I noticed that the LogViewerPlugin WebAdmin panel displays correctly. Well, it mostly displays correctly. The only minor thing is that I might expect the Tail and Search panels to be left aligned. Screen capture to follow.

Changed 5 years ago by rjollos

Large screen capture on 2009-11-17

comment:23 Changed 5 years ago by rjollos

The screen capture is fairly large, as the problem is most obvious when the browser window is maximized on a 1920 x 1080 resolution display.

comment:24 Changed 5 years ago by izzy

  • Resolution set to invalid
  • Status changed from assigned to closed

Thanks for the detailed report! This means, the (original) issue is solved (and was not caused by the LogViewerPlugin - which is very good news!

As for your alignment issue: That's as designed. I personally hate those wide-screen displays - so I won't change this. Nevertheless, as the page of LogViewerPlugin says, there is an easy solution for you: You just need a little CSS. Either in your browser (if supported - like with Stylish or Greasemonkey for Firefox) for your personal convenience - or for your entire trac installation (see http://trac.edgewall.org/wiki/TracInterfaceCustomization for details). The only line of code required for this could be:

#li_tail, #li_search { float:left !important; }

They might change their order then (i.e. Tail may be the right-most item, and the search mask immediately before it) - but that won't hurt you, I guess.

As the problem seems solved, I'm closing this ticket (if you wonder about the "invalid" - it wasn't LogViewerPlugin having the bug ;).

comment:25 Changed 5 years ago by rjollos

Thank you for all of your help!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from izzy. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.