Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7660 closed defect (fixed)

[patch] Clicking notification checkbox doesn't toggle notification status (in chrome)

Reported by: penmark Owned by: martin_s
Priority: normal Component: WatchlistPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

  • watchlistplugin/tracwatchlist/htdocs/js/watchlist.dev.js

    diff --git a/watchlistplugin/tracwatchlist/htdocs/js/watchlist.dev.js b/watchlistplugin/tracwatchlist/htdocs/js/watchlist.dev.js
    index 7a94650..567fe0e 100644
    a b jQuery(document).ready(function() { 
    6363    return false; 
    6464  }); 
    6565 
     66  $('a.notifyon input, a.notifyoff input').click(function(e) { 
     67    window.location = $(this).parent().attr('href') 
     68  }) 
    6669}); 

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by martin_s

Please give more information. Which exact version of the WatchlistPlugin are you using?
I would also need the version of chrome and your OS.

Could you try this with the current dev branch if you use Trac 0.12 or with the dev branch in r8430 if you use Trac 0.11. Should be fixed there using AJAX calls.

comment:2 Changed 4 years ago by martin_s

  • Resolution set to worksforme
  • Status changed from new to closed

I now [8724] updated the dev branch to be again compatible to Trac 0.11.
I tested this version with both Trac 0.11 and 0.12 and Google Chrome 6.0.472.55 under Ubuntu Linux 10.04. It works fine so I mark this ticket now as worksforme.

Feel free to install the above develop version or wait for the next official release which should come soon (next few weeks).

comment:3 Changed 4 years ago by penmark

  • Trac Release changed from 0.11 to 0.12

Sorry missed to set the correct trac version. The watchlistplugin is 0.12 @8582. My OS is Ubuntu 10.04 and I use Chrome 6.0.472.55-r58392. The problem was

<a href="toggle notify"><input type="checkbox"></a>

At least in chrome, clicking just outside the checkbox causes the link to be clicked, clicking the checkbox doesn't propagate to the anchor element.

comment:4 Changed 4 years ago by martin_s

  • Resolution worksforme deleted
  • Status changed from closed to reopened

comment:5 Changed 4 years ago by martin_s

  • Resolution set to fixed
  • Status changed from reopened to closed

I installed the current 0.12 branch now and tested it with Google Chrome.
I could recreate your issue -- so it isn't a worksforme after all :-) .

However, this is fixed in the current dev branch so comment:2 still applies.

Thanks for reporting this, even it was fixed in the meantime.

comment:6 Changed 4 years ago by martin_s

Just had a look on the relevant JS-code again and figured out, that the toggling of the notification wasn't correctly supported! :-) While the check-box got toggled only the initial action (either 'notifyon' or 'notifyoff') was send every time.

I fixed this now in [8727] in dev.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from martin_s. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.