Modify

Opened 3 years ago

Closed 3 years ago

#8399 closed defect (fixed)

It doesn't work in 0.12.1

Reported by: zwei22@… Owned by: rjollos
Priority: high Component: DuplicateTicketSearchPlugin
Severity: critical Keywords: regex
Cc: Trac Release: 0.12

Description (last modified by rjollos)

I have installed trac(0.12.1) and I want to that the plugin work in my trac well.
However, It doesn't work, so I see its source, tracDupeSearch.js.
In the source, I changed code about regex expression and it is working well. It's below

- var summaryRegex = /#(\d+)<\/span>:\s*([a-z0-9\-\_\ ]+):\s*(.*)\s*\(([a-z0-9\-\_\ ]+)(?:\: ([a-z0-9\-\_\ ]+))?\)$/i;
+ var summaryRegex = /#(\d+)<\/span>:\s*(.*):\s*(.*)\s*\((.*)(?:\: (.*))?\)$/i;

Attachments (0)

Change History (6)

comment:1 follow-up: Changed 3 years ago by rjollos

  • Description modified (diff)

What language do you use on your Trac installation?

comment:2 in reply to: ↑ 1 Changed 3 years ago by zwei22@…

I use korean in my trac.

Replying to rjollos:

What language do you use on your Trac installation?

comment:3 Changed 3 years ago by rjollos

  • Owner changed from gregmac to rjollos
  • Priority changed from normal to high
  • Status changed from new to assigned

This might resolve the issue in #7382 as well. I'll apply the patch shortly.

comment:4 Changed 3 years ago by rjollos

I don't understand the regex, but it seems to work, so I'm going to go ahead and apply the patch.

comment:5 Changed 3 years ago by rjollos

Before and after applying the patch, I created a ticket with summary 한국어/조선말 and I got a subsequent match in both cases. So, I'm not exactly sure why it wasn't working for you and the reporter in #7382, but was working fine for me.

comment:6 Changed 3 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [9784]) Modified regex to support unicode characters in match. Fixes #8399.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.