Modify

Opened 4 years ago

Closed 2 years ago

#8808 closed enhancement (fixed)

Support preview rendering

Reported by: sgifford Owned by: rjollos
Priority: normal Component: MovieMacro
Severity: normal Keywords:
Cc: juha.mustonen@… Trac Release: 0.11

Description

MovieMacro should be a preview renderer for movie types. That makes it show up whenever a recognized video file is shown, without the user having to download the file or embed it with MovieMacro.

I will attach a patch that implements this.

Attachments (1)

moviemacro-preview-render.patch (2.1 KB) - added by sgifford 4 years ago.
Patch to support preview rendering

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by sgifford

Patch to support preview rendering

comment:1 Changed 2 years ago by rjollos

  • Cc juha.mustonen@… added; anonymous removed

comment:2 in reply to: ↑ description Changed 2 years ago by rjollos

  • Owner changed from lcordier to rjollos
  • Status changed from new to assigned

Replying to sgifford:

That makes it show up whenever a recognized video file is shown, without the user having to download the file or embed it with MovieMacro.

The two cases I think that of where this would apply are the attachment page and the browser. The next checkin will add support for both. Please let me know if you can think of any others.

comment:3 Changed 2 years ago by rjollos

(In [12037]) Refs #8808:

  • Added preview rendering of movies. Previews are rendered for attachments and repository files. For preview rendering to be available for all attachments, set the value of the [mimeviewer] max_preview_size configuration entry to greater than or equal to the value of the [attachment] max_size configuration entry in trac.ini.

The initial version of the patch was by sgifford. Thanks!

comment:4 Changed 2 years ago by rjollos

Feedback from testing is appreciated. You'll need to enable the new movie.web_ui component in trac.ini, or through the web admin panel.

comment:5 Changed 2 years ago by rjollos

(In [12038]) Refs #7422, #8808: Renamed 0.11 directory to trunk.

comment:6 Changed 2 years ago by rjollos

I was having a strange problem with the pages needing numerous refreshes initially, before the IHTMLPreviewRenderer first seemed to register. I think this was probably just an issue with my development environment, but please let me know if you encounter any similar issues.

comment:7 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.