Modify

Opened 4 years ago

Closed 21 months ago

#7422 closed enhancement (fixed)

MovieMacro for 0.12

Reported by: anonymous Owned by: rjollos
Priority: normal Component: MovieMacro
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

is MovieMacro working on trac 0.12? I have installed last version of MovieMacro macros, but it don't work propetly.

Attachments (0)

Change History (12)

comment:1 Changed 4 years ago by anonymous

  • Type changed from task to enhancement

comment:3 Changed 22 months ago by juha.mustonen@…

Alternative solution is to change paths in get_absolute_url(?)

  • movie/macro.

    old new  
    4848        return url 
    4949 
    5050    if scheme in ('htdocs', 'chrome'): 
    51         return ujoin(base, 'chrome', path) 
     51        return ujoin(base, 'chrome', netloc, path) 
    5252 
    5353    if scheme in ('source',): 
    5454        return ujoin(base, 'export', path) 
     
    5757        return ujoin(base, 'raw-attachment/ticket', path) 
    5858 
    5959    if scheme in ('wiki',): 
    60         return ujoin(base, 'raw-attachment/wiki', path) 
     60        return ujoin(base, 'raw-attachment/wiki', netloc, path) 
    6161 
    6262    return url 

comment:4 Changed 22 months ago by juha.mustonen@…

And naturally the ticket path needs to be changed as well. Support for source (or other VCS backends on that matter) has not been changed/tested.

  • movie/macro.py

     
    4848        return url 
    4949 
    5050    if scheme in ('htdocs', 'chrome'): 
    51         return ujoin(base, 'chrome', path) 
     51        return ujoin(base, 'chrome', netloc, path) 
    5252 
    5353    if scheme in ('source',): 
    5454        return ujoin(base, 'export', path) 
    5555 
    5656    if scheme in ('ticket',): 
    57         return ujoin(base, 'raw-attachment/ticket', path) 
     57        return ujoin(base, 'raw-attachment/ticket', netloc, path) 
    5858 
    5959    if scheme in ('wiki',): 
    60         return ujoin(base, 'raw-attachment/wiki', path) 
     60        return ujoin(base, 'raw-attachment/wiki', netloc, path) 
    6161 
    6262    return url 

comment:5 Changed 22 months ago by rjollos

  • Owner changed from lcordier to rjollos

The code should be refactored to make better use of the Trac API. I don't see much activity on the plugin lately, so I'll assume it's unmaintained and push a fix in a few moments.

comment:6 Changed 22 months ago by rjollos

Btw, I'm using these example files for testing: http://www.mediacollege.com/adobe/flash/video/tutorial/example-flv.html

comment:7 Changed 22 months ago by rjollos

(In [12015]) Refs #7422: (0.2dev)

  • Refactored code to make better use of the Trac API when constructing URLs. This should resolve issues with incorrect URLs.

comment:8 Changed 22 months ago by rjollos

Please report back if you are able to test, and if I get some positive feedback I will close out the ticket.

comment:9 Changed 22 months ago by anonymous

Confirmed: version 0.2dev-r12015 seems to work just fine.

Sources tested:

  • wiki attachment
  • ticket attachment
  • youtube url

comment:10 Changed 22 months ago by rjollos

  • Status changed from new to assigned

Thanks. I'm going to push a few more patches. I'll CC you on the tickets in case you might have an interested in testing out a newer version of the plugin.

comment:11 Changed 22 months ago by rjollos

(In [12038]) Refs #7422, #8808: Renamed 0.11 directory to trunk.

comment:12 Changed 21 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.