Ticket #7422 (closed enhancement: fixed)

Opened 3 years ago

Last modified 7 months ago

MovieMacro for 0.12

Reported by: anonymous Assigned to: rjollos
Priority: normal Component: MovieMacro
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

is MovieMacro working on trac 0.12? I have installed last version of MovieMacro macros, but it don't work propetly.

Attachments

Change History

07/27/10 12:14:07 changed by anonymous

  • type changed from task to enhancement.

06/24/11 16:42:46 changed by eamonn.power@gmail.com

changing

htdocs://movie/img/black.jpg -> htdocs://movie/movie/img/black.jpg

and

htdocs://movie/swf/FlowPlayerDark.swf -> htdocs://movie/movie/swf/FlowPlayerDark.swf

in macro.py makes it work again.

09/12/12 14:25:01 changed by juha.mustonen@digia.com

Alternative solution is to change paths in get_absolute_url(?) 

--- movie/macro.org.py	2012-09-12 14:44:23.749186216 +0300
+++ movie/macro.py	2012-09-12 15:09:01.080156064 +0300
@@ -48,7 +48,7 @@
         return url

     if scheme in ('htdocs', 'chrome'):
-        return ujoin(base, 'chrome', path)
+        return ujoin(base, 'chrome', netloc, path)

     if scheme in ('source',):
         return ujoin(base, 'export', path)
@@ -57,7 +57,7 @@
         return ujoin(base, 'raw-attachment/ticket', path)

     if scheme in ('wiki',):
-        return ujoin(base, 'raw-attachment/wiki', path)
+        return ujoin(base, 'raw-attachment/wiki', netloc, path)

     return url

09/18/12 08:35:20 changed by juha.mustonen@digia.com

And naturally the ticket path needs to be changed as well. Support for source (or other VCS backends on that matter) has not been changed/tested. 

--- movie/macro.py	2012-09-12 14:44:23.749186216 +0300
+++ movie/macro.py	2012-09-18 09:27:59.146865075 +0300
@@ -48,16 +48,16 @@
         return url

     if scheme in ('htdocs', 'chrome'):
-        return ujoin(base, 'chrome', path)
+        return ujoin(base, 'chrome', netloc, path)

     if scheme in ('source',):
         return ujoin(base, 'export', path)

     if scheme in ('ticket',):
-        return ujoin(base, 'raw-attachment/ticket', path)
+        return ujoin(base, 'raw-attachment/ticket', netloc, path)

     if scheme in ('wiki',):
-        return ujoin(base, 'raw-attachment/wiki', path)
+        return ujoin(base, 'raw-attachment/wiki', netloc, path)

     return url

09/18/12 11:40:21 changed by rjollos

  • owner changed from lcordier to rjollos.

The code should be refactored to make better use of the Trac API. I don't see much activity on the plugin lately, so I'll assume it's unmaintained and push a fix in a few moments.

09/18/12 11:41:00 changed by rjollos

Btw, I'm using these example files for testing: http://www.mediacollege.com/adobe/flash/video/tutorial/example-flv.html

09/18/12 11:52:21 changed by rjollos

(In [12015]) Refs #7422: (0.2dev)

  • Refactored code to make better use of the Trac API when constructing URLs. This should resolve issues with incorrect URLs.

09/19/12 16:49:25 changed by rjollos

Please report back if you are able to test, and if I get some positive feedback I will close out the ticket.

09/20/12 07:12:53 changed by anonymous

Confirmed: version 0.2dev-r12015 seems to work just fine.

Sources tested:

  • wiki attachment
  • ticket attachment
  • youtube url

09/20/12 20:48:29 changed by rjollos

  • status changed from new to assigned.

Thanks. I'm going to push a few more patches. I'll CC you on the tickets in case you might have an interested in testing out a newer version of the plugin.

09/21/12 01:31:17 changed by rjollos

(In [12038]) Refs #7422, #8808: Renamed 0.11 directory to trunk.

10/31/12 07:22:21 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #7422 (MovieMacro for 0.12)




Change Properties
Action