Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#8877 closed defect (duplicate)

menu item links fail on trac installations in the root of the server.

Reported by: david.killick@… Owned by: cbalan
Priority: normal Component: MenusPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

In our trac installation, trac is installed at the root of our server.

When an item's href is set to (say)

ticket_defect.href = /newticket?type=defect

The resulting URI is

//newticket?type=defect

which causes the browser to make requests to a non-existent server.

Investigating a similar error in another plugin suggested it may be due to 'ref.href()' returning '/'. Not sure if it is the case here.

Attachments (0)

Change History (7)

comment:1 Changed 3 years ago by rjollos

  • Resolution set to duplicate
  • Status changed from new to closed

comment:2 Changed 3 years ago by rjollos

(In [11038]) Fixes #7399, Refs #7680, #8877, #8953: (0.1.1) Links were invalid when Trac was accessed from the top-most path.

comment:3 Changed 3 years ago by rjollos

(In [11039]) Fixes #7399, Refs #7680, #8877, #8953: (0.1.1) [11038] was the wrong solution. This fix should work better.

comment:4 Changed 3 years ago by rjollos

(In [11154]) Fixes #7399, Refs #7680, #8877, #8953: Allow Href to take care of path joining. Tested in 0.11 and 0.13dev-r10909.

comment:5 Changed 3 years ago by rjollos

(In [11155]) Fixes #7399, Refs #7680, #8877, #8953: Removed egg and pydev files accidentally committed in [11154].

comment:6 Changed 3 years ago by rjollos

(In [11156]) Fixes #7399, Refs #7680, #8877, #8953: Removed egg and pydev files accidentally committed in [11154].

comment:7 Changed 3 years ago by rjollos

(In [11166]) Fixes #7399, Refs #7680, #8877, #8953: Yet another attempt to fix invalid links when req.href = '/'. If the href for a menu item specifies a relative path, the trailing forward slashes are stripped from req.href() so that the two cases are handled: 1) req.href() is '/' and 2) req.href() is '/somepath'.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.