Ticket #8878 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

TestManagerForTracPlugin does not play well with MenusPlugin

Reported by: david.killick@wcn.co.uk Assigned to: seccanj
Priority: normal Component: TestManagerForTracPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

When accessing pages under the Test Manager, we get the error the $ is not a method from the javascript associated with the menus plugin. No other pages give this error.

It seems to be related to the introduction of a second jquery instance at line 571 in wiki.py.

Attachments

wiki.py (28.6 kB) - added by seccanj on 06/11/11 23:28:43.
Fixed code

Change History

06/09/11 10:56:16 changed by seccanj

Hi David, thanks for reporting this and for the debugging hints you give :D

As you may guess I didn't test the plugin with this MenusPlugin, anyway while adding the new jQuery package I feared something wrong would be reported soon :(

I'll take a look during this w/e.

Ciao, Roberto

06/11/11 23:28:11 changed by seccanj

Hi David, I found the problem and maybe fixed it.

Please find in attachment the modified wiki.py file, to be replaced inside the "testman4trac/trunk/testmanager" directory.

Build again and replace the plugin, clean your browser's cache and try again.

I've seen this fixes the problem while coexisting with another plugin, so please, let me know if this fixes the problem in your environment.

Ciao, Roberto

06/11/11 23:28:43 changed by seccanj

  • attachment wiki.py added.

Fixed code

06/15/11 17:54:11 changed by david.killick@wcn.co.uk

Hi Roberto,

This patch seems to have mostly fixed the problem. The menus now render correctly, and there are no JS errors.

On TestManager? pages, the menus must be clicked to open then, however, on all other pages the menus open by 'hovering' the mouse over them. Not sure whether this would be a TestManager? or a MenusPlugin issue.

06/16/11 12:07:50 changed by seccanj

  • status changed from new to closed.
  • resolution set to fixed.

Hi David, glad to hear the fix works :D

I've recently made another little change that actually removes the need for a menu in that place, unless you have defined more than one (custom) outcome for any of the color (green, yellow, red).

This should simplify selecting the verdict of a test case manually.

I'll release your fix and the above mentioned change asap, in 1.4.6.

Ciao, Roberto

06/18/11 17:11:01 changed by seccanj

Released in 1.4.6.

Add/Change #8878 (TestManagerForTracPlugin does not play well with MenusPlugin)




Change Properties
Action