Opened 5 years ago

Closed 5 years ago

Desc/Asc sort issue

Reported by: Owned by: sdegrande Ryan J Ollos normal DownloadsPlugin normal Ryan J Ollos 1.0

Description

Changing the ascending/descending sort order of a column (via the triangular arrows on the HTML table, or via the configuration parameters in trac.ini) has no impact.

The proposed attached patch fixes that issue.

Thanks for your great work !

comment:1 Changed 5 years ago by sdegrande

I was not able to attach a file on the ticket, so here is the diff:

diff -r ec2c58e517b9 downloadsplugin/0.12/tracdownloads/api.py

comment:2 in reply to:  description Changed 5 years ago by Ryan J Ollos

Owner: changed from Radek Bartoň to Ryan J Ollos new → assigned

Changing the ascending/descending sort order of a column (via the triangular arrows on the HTML table, or via the configuration parameters in trac.ini) has no impact.

My observation was that changing the sort direction by clicking on the arrow worked correctly, but setting the option in trac.ini had no effect.

comment:3 Changed 5 years ago by Ryan J Ollos

Resolution: → fixed assigned → closed

(In [12067]) Fixes #10280: FIX: specifying a sort direction in trac.ini had no effect. Thanks to sdegrande for the patch.

Removed egg accidentally committed in [12064].

comment:4 follow-up:  5 Changed 5 years ago by Ryan J Ollos

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

comment:5 in reply to:  4 ; follow-up:  6 Changed 5 years ago by sdegrande

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

I'll will do ASAP.

Thanks for your work.

comment:6 in reply to:  5 Changed 5 years ago by sdegrande

Please report back if you have a chance to test the latest trunk. Note the directory reoganization in [12063:12066].

I'll will do ASAP.

Thanks for your work.

I just tested r12139.

Works well. Thanks.

Modify Ticket

Change Properties