Template enhancement

[sdegrande]

I changed a bit the templates, adding some divs where needed, in order to be able to mimic the new 1.0 design :

Here is the proposed patch.

I can also upload the CSS I used (which would be to be reworked, since I'm far from being a CSS expert).

Thanks for your great work !

[Ryan J Ollos]

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed. I'm not very proficient in CSS either, so it will take me a bit of time to get this committed.

[Ryan J Ollos]

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

[Ryan J Ollos]

sdegrande: would you consider rebasing this patch on the 1.0 branch so that it applies cleanly? Thanks!

[sdegrande]

Replying to rjollos:

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

Well, I think that you know my humble opinion on that point... Just move on !

[sdegrande]

I attached a rebased version of the patch (attachment:adapt_template_to_trac_new_style.patch​), also including the CSS changes to have rounded box around lists and list elements, to mimic new Trac style.

[Ryan J Ollos]

In 14884:

0.10dev: Use equivalent functions passed in chrome dictionary. Refs #10593.

[Ryan J Ollos]

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

[Ryan J Ollos]

In 14885:

0.10dev: Better styling for Trac 1.0. Fixes #10593.

Patch by sdegrande.

[sdegrande]

Replying to rjollos:

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

Thanks.

I do not consider myself as a good enough python coder to avoid a code review from an expert if I was to submit some 'complex changes'. So yes, I would first post a ticket.

[Ryan J Ollos]

In 15151:

0.10dev: Implement change that was overlooked in [14884]

Refs #10593, #12640.

[Ryan J Ollos]

In 15547:

0.10dev: Implement another change that was overlooked in [14884]

Refs #10593.
Fixes #12762.