Modify

Opened 4 years ago

Closed 12 months ago

Last modified 2 months ago

#10593 closed enhancement (fixed)

Template enhancement

Reported by: sdegrande Owned by: sdegrande
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Blackhex Trac Release: 1.0

Description

I changed a bit the templates, adding some divs where needed, in order to be able to mimic the new 1.0 design :

Here is the proposed patch.

I can also upload the CSS I used (which would be to be reworked, since I'm far from being a CSS expert).

Thanks for your great work !

Attachments (4)

forum-list.png (40.4 KB) - added by sdegrande 4 years ago.
topic.png (50.1 KB) - added by sdegrande 4 years ago.
rounded_template.patch (8.3 KB) - added by sdegrande 4 years ago.
adapt_template_to_trac_new_style.patch (9.7 KB) - added by sdegrande 12 months ago.

Download all attachments as: .zip

Change History (16)

Changed 4 years ago by sdegrande

Changed 4 years ago by sdegrande

Changed 4 years ago by sdegrande

comment:1 follow-up: Changed 4 years ago by rjollos

  • Cc Blackhex added; rjollos removed
  • Owner changed from Blackhex to rjollos

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed. I'm not very proficient in CSS either, so it will take me a bit of time to get this committed.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 12 months ago by rjollos

  • Status changed from new to accepted

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

comment:3 Changed 12 months ago by rjollos

sdegrande: would you consider rebasing this patch on the 1.0 branch so that it applies cleanly? Thanks!

comment:4 in reply to: ↑ 2 Changed 12 months ago by sdegrande

Replying to rjollos:

Replying to rjollos:

I'll keep this ticket on my radar, but I'd like to avoid forking for 1.0 until we get a few more bugs fixed.

My future self says ... Unacceptable! Supporting old versions of Trac is a waste of time. Branch and support 1.0 and later :)

Well, I think that you know my humble opinion on that point... Just move on !

Changed 12 months ago by sdegrande

comment:5 Changed 12 months ago by sdegrande

I attached a rebased version of the patch (attachment:adapt_template_to_trac_new_style.patch), also including the CSS changes to have rounded box around lists and list elements, to mimic new Trac style.

comment:6 Changed 12 months ago by rjollos

In 14884:

0.10dev: Use equivalent functions passed in chrome dictionary. Refs #10593.

comment:7 follow-up: Changed 12 months ago by rjollos

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

comment:8 Changed 12 months ago by rjollos

  • Resolution set to fixed
  • Status changed from accepted to closed

In 14885:

0.10dev: Better styling for Trac 1.0. Fixes #10593.

Patch by sdegrande.

comment:9 Changed 12 months ago by rjollos

  • Owner changed from rjollos to sdegrande

comment:10 in reply to: ↑ 7 Changed 12 months ago by sdegrande

Replying to rjollos:

sdegrande: You now have commit access to both the DiscussionPlugin and DownloadsPlugin. Feel free to push patches directly, or post to a ticket first if for any reason you'd like a second opinion.

Thanks.

I do not consider myself as a good enough python coder to avoid a code review from an expert if I was to submit some 'complex changes'. So yes, I would first post a ticket.

comment:11 Changed 6 months ago by rjollos

In 15151:

0.10dev: Implement change that was overlooked in [14884]

Refs #10593, #12640.

comment:12 Changed 2 months ago by rjollos

In 15547:

0.10dev: Implement another change that was overlooked in [14884]

Refs #10593.
Fixes #12762.

Add Comment

Modify Ticket

Action
as closed The owner will remain sdegrande.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.