installing ChangeLogMacro from trunk forces Trac deployment to update

[anonymous]

I was running Trac 0.12.2; I downloaded the zip file of ChangeLogMacro, ran python ./trunk/setup.py install to install the trunk version. While this completed successfully, it forced my entire Trac deployment to upgrade. (each project reported an error, and required trac-admin /proj upgrade to be run) This was unexpected and could cause problems for others.

[Ryan J Ollos]

Is the error text Environment needs upgrade? I don't see how ChangeLogMacro could be forcing an upgrade since it doesn't implement IEnvironmentUpgradeParticipant.

[anonymous]

Unfortunately, I didn't record the error, and I can't reproduce it. Since it was on a production instance, I went ahead with the upgrade.

[Ryan J Ollos]

Okay, thanks for the info. I will try to reproduce the error and follow-up here in a bit.

[Ryan J Ollos]

I think I see what the issue is now. This is yet another reason to avoid install_requires=['Trac >= X.Y'] in setup.py.

[Ryan J Ollos]

In 13267:

Fixes #10607: Don't use install_requires to enforce a Trac version constraint, as it can inadvertently upgrade a user's installation.

[Steffen Hoffmann]

Replying to rjollos:

I think I see what the issue is now. This is yet another reason to avoid install_requires=['Trac >= X.Y'] in setup.py.

Good catch.

[Ryan J Ollos]

In 13285:

Refs #10797: Code cleanup: PEP-0008 changes, removed unused imports including unused import of pisa in web_ui.py. Removed Trac from install_requires, as this has been shown to cause problems (see #10607).

[Ryan J Ollos]

In 13849:

0.2: web_context is only available since Trac 1.0, so enforce a minimum Trac version at runtime. Refs #8365, #10607.

[Ryan J Ollos]

In 14819:

0.4dev: Require Trac in setup.py. Refs #8365, #10607.