Modify ↓

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10797 closed defect (fixed)

Update to xhtml2pdf from pisa (as pisa is now obsolete)

Reported by: charlie@… Owned by: Ryan J Ollos
Priority: normal Component: TracWikiPrintPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by Ryan J Ollos)

Following chages are necessary :

  1. Two files needs to be changed : 
    wikiprint.py
web_ui.py
  • replace import ho.pisa as pisa with import xhtml2pdf.pisa as pisa
  1. Installer needs to be changed (not done yet)

If someone will create a new version, please do not omit this. Maybe I will do it in the future as there are other 3 enhancements already done and not published yet.

Attachments (0)

Change History (7)

comment:1 Changed 11 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 11 years ago by Ryan J Ollos

Owner: changed from Álvaro Iradier to Ryan J Ollos
Status: new → assigned

Thanks, I will take a look and likely push the change.

comment:3 Changed 11 years ago by tekknokrat

Can you please push this patch into the plugin? I am planning to deploy wikiprint on several trac instances and would like to avoid massive patching ;-)

comment:4 Changed 11 years ago by Ryan J Ollos

Yes, sorry for the delay. I'll push it today.

comment:5 Changed 11 years ago by Ryan J Ollos

In 13285:

Refs #10797: Code cleanup: PEP-0008 changes, removed unused imports including unused import of pisa in web_ui.py. Removed Trac from install_requires, as this has been shown to cause problems (see #10607).

comment:6 Changed 11 years ago by Ryan J Ollos

Resolution: → fixed
Status: assigned → closed

In 13286:

Fixes #10797: Update import of pisa to account for new module name. Thanks to charlie@… for the patch.

comment:7 Changed 11 years ago by Ryan J Ollos

In 13287:

Refs #10797: Bumped version to 1.9.3dev.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.