[Patch] Use jQuery UI provided by Trac in 1.0 and later

[Ryan J Ollos]

Trac 1.0 provides jQuery UI. The attached patch uses jQuery UI from Trac when the Trac version is >= 1.0.

[Ryan J Ollos]

I have repository-wide commit access, so I'd be happy to push this change if you approve.

[Jun Omae]

Use hasattr(Chrome, 'add_jquery_ui')

[Jun Omae]

IMO, it would be better to check Chrome.add_jquery_ui attribute instead of Trac version, t10655-r7112-2.diff​.

[Ryan J Ollos]

Yeah, I agree that Jun's patch is the better approach. I'm glad you brought this up, because after I made the first patch, I started thinking one day of a similar approach:

try:
    Chrome(self.env).add_jquery_ui(req)
except AttributeError:
    add_script(req, 'adminenumlistplugin/jquery-ui-custom.js')

I'm not sure of any advantages of try/except vs hasattr; I've seen both patterns used in code quite a bit and I'm fairly new to Python. From reading the docs though, it looks like ​hasattr effectively does the same behind the scenes by calling getattr in a try/except, so the approach taken in the patch is probably cleaner and more readable.

[Ryan J Ollos]

Btw, I'll just go ahead and push this change in 2 weeks (per guidelines in AdoptingHacks), if we don't hear from nonplus by then.

[Ryan J Ollos]

(In [12413]) Fixes #10655: (1.1dev) Use jQuery UI bundled with Trac core when available (1.0 and later). Thanks to Jun Omae for improving the patch. Removed some uncessary imports.