#10706 closed defect (fixed)
New install will not be possible with Trac 1.0
| Reported by: | Ryan J Ollos | Owned by: | Steffen Hoffmann |
|---|---|---|---|
| Priority: | normal | Component: | VotePlugin |
| Severity: | normal | Keywords: | install db rollback |
| Cc: | Steffen Hoffmann | Trac Release: | 1.0 |
Description
This plugin most likely won't work in Trac 1.0 for the reasons described in #9521. The plugin needs to query the table to get the schema version from the system table rather than relying on a check for the existence of the votes table, which . The latter results in an exception when the table is not present, which is an approach that no longer works with Trac 1.0.
Attachments (0)
Change History (9)
comment:1 follow-up: 2 Changed 12 years ago by
| Keywords: | install db rollback added |
|---|
comment:2 follow-up: 3 Changed 12 years ago by
| Status: | new → assigned |
|---|
Replying to hasienda:
Do you plan to fix it yourself?
Yeah, I'm going to use it as an opportunity to study and better understand your fix. I'll certainly appreciate if you have a chance to code review my patch though!
comment:3 Changed 12 years ago by
Replying to rjollos:
...
I'll certainly appreciate if you have a chance to code review my patch though!
Sure.
comment:4 follow-up: 5 Changed 12 years ago by
Just testing this plugin for support of user ID changes in AccountManagerPlugin.
Thanks to modifications of Trac's environment upgrade detection code (giving every setup participant an own db connection instead of passing one around) this plugin works with Trac 1.0 too.
Still we should introduce schema tracking in system db table. And there are more improvements, that would justify moving to a new db schema. But I'll open a new ticket for that enhancement request for the sake of better tracking.
comment:5 Changed 12 years ago by
Replying to hasienda:
Thanks to modifications of Trac's environment upgrade detection code (giving every setup participant an own db connection instead of passing one around) this plugin works with Trac 1.0 too.
Oh, good to know. I didn't realize that a fix had been put in place prior to the 1.0 release.
comment:6 Changed 12 years ago by
| Owner: | changed from Ryan J Ollos to Steffen Hoffmann |
|---|---|
| Status: | assigned → new |
comment:7 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [12773]) TracVote: Don't call rollback() from environment_needs_upgrade(), closes #10706.
This is patterned after [12124] for TagsPlugin. See #9521 for details on implications of probing the Trac db for table existence like done before.
comment:8 Changed 12 years ago by
comment:9 Changed 12 years ago by
(In [13090]) VotePlugin: Finish version nummer corrections after [13088:13089], refs #10706.
Hey, but the experience gained by working on #9521 should make the fix nearly a no-brainer, until I get around to do the rework I dreamed about earlier this year.
Do you plan to fix it yourself?