Modify ↓

Opened 12 years ago

Closed 4 years ago

#10731 closed task (fixed)

Templates don't follow common naming convention

Reported by: Ryan J Ollos Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Olemis Lang Trac Release:

Description

The templates don't follow the common naming convention for Trac templates, which appears to be derived from the PEP8 naming convention for modules. The template names should be all lower case, with underscores allowed.

Attachments (0)

Change History (7)

comment:1 Changed 12 years ago by Ryan J Ollos

For example, rename peerReviewBrowser.html -> peer_review_browser.html (or pr_browser or whatever, as long as a consistent convention is used).

comment:2 Changed 11 years ago by Ryan J Ollos

Status: new → assigned

comment:3 Changed 9 years ago by Cinc-th

Owner: changed from Ryan J Ollos to Cinc-th

comment:4 Changed 8 years ago by Cinc-th

In 15580:

PeerReviewPlugin: renamed peerReviewBrowser.py and peerReviewBrowser.html to repobrowser.py and repobrowser.html. Refs #10731.

Bumped version to V3.1dev.

comment:5 Changed 5 years ago by Cinc-th

In 17445:

PeerReviewPlugin: refactoring of PeerReviewView. Renamed template to peerreview_view.html.

Refs #13583, #10731

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 4 years ago by Cinc-th

In 18245:

PeerReviewPlugin: missed template while converting to Jinja2. Fixed naming of a Genshi template.

Refs #13980, #10731

comment:7 Changed 4 years ago by Cinc-th

Resolution: → fixed
Status: assigned → closed

In 18246:

PeerReviewPlugin: fixed naming of Genshi templates to follow common naming conventions.

Closes #10731

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.