Modify

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#10820 closed defect (fixed)

Link rules changed in Trac 1.0 (plug-in not detecting new link types)

Reported by: paulcoddington@… Owned by: Geert
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords:
Cc: Geert Trac Release: 1.0

Description

A heads up that the interpretation of text as links in Trac 1.0 is somewhat different to that of previous versions.

For example:

This sentence Contains/Link/Now where it didn't before.

The phrase "Contains/Link/Now" is now considered a link by Trac 1.0, but it is not detected by WantedPagesPlugin.

Attachments (0)

Change History (6)

comment:1 Changed 3 years ago by Ryan J Ollos

Owner: changed from Justin Francis to Ryan J Ollos
Status: newassigned

comment:2 Changed 3 years ago by Ryan J Ollos

Component: WantedPagesPluginWantedPagesMacro

Renaming plugin from WantedPagesPlugin to WantedPagesMacro.

comment:3 Changed 3 years ago by Ryan J Ollos

Cc: Geert added; anonymous removed

See related discussion in trac:#11359.

comment:4 Changed 3 years ago by Ryan J Ollos

Owner: changed from Ryan J Ollos to Geert

Reassigning tickets to glinders, assuming adoption request in #11491 will be approved.

comment:5 Changed 3 years ago by Ryan J Ollos

I'm not sure if we discussed this before, but Trac 1.0 supports Python 2.5-2.7, Trac 1.2 will support 2.6-2.7. The use of OrderedDict in [14058] will result in the plugin only being usable with Python 2.7.

One solution would be to add the OrderedDictionary for Python 2.4 to a compat.py module:

try:
    from collections import OrderedDict
except ImportError:
    from wantedpages.compat import OrderedDict
Last edited 3 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 2 years ago by Geert

Resolution: fixed
Status: assignedclosed

This feature was added automagically in changeset r14058.

The new way of checking links incorporates this automatically, because it renders the Wiki pages first and then looks for unresolved links.

Also added changeset r14410 and r14411: These add a few test cases and remove the dependency on OrderedDict()

Last edited 2 years ago by Geert (previous) (diff)

Modify Ticket

Action
as closed The owner will remain Geert.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.