Modify

Opened 4 years ago

Closed 4 years ago

#11491 closed task (fixed)

Adoption Request for WantedPagesPlugin

Reported by: Geert Owned by: Justin Francis
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords:
Cc: Trac Release:

Description

I would like to adopt WantedPagesPlugin

Attachments (0)

Change History (10)

comment:1 Changed 4 years ago by Ryan J Ollos

This should really be WantedPagesMacro, so I'm going to rename it now.

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 4 years ago by Ryan J Ollos

Component: WantedPagesPluginWantedPagesMacro

Renaming plugin from WantedPagesPlugin to WantedPagesMacro.

comment:3 Changed 4 years ago by Ryan J Ollos

Page content moved to WantedPagesMacro and redirect added at WantedPagesPlugin.

comment:4 Changed 4 years ago by Ryan J Ollos

Type: defecttask

comment:5 Changed 4 years ago by Ryan J Ollos

In 13565:

Fixes #8726, Refs #11491:

  • Bumped version to 0.4dev.
  • Modified entry point. Plugin is now enabled as wantedpages.* = enabled.
  • Renamed from WantedPagesPlugin to WantedPagesMacro.
  • Modified test cases to use trac.wiki.formatter.
  • PEP-0008 changes.
  • Use WikiMacroBase as base class and IWikiMacroProvider interface from Trac 0.11 and later.

comment:6 Changed 4 years ago by Ryan J Ollos

comment:7 Changed 4 years ago by Ryan J Ollos

Okay, changes that I had planned are completed. Please let me know if you spot any issues.

One thought I had, maybe we can use rules from parser.py rather than trying to redefine them in the plugin code. That might allow the plugin to implicitly handle changes such as #9639 and #10820.

comment:8 Changed 4 years ago by Ryan J Ollos

glinders: In case you aren't familiar with running the unit tests, I just wanted to mention that you can execute them in a few different ways:

  • $ PYTHONPATH=. python setup.py test
  • $ PYTHONPATH=. python -m wantedpages.tests.__init__
  • $ PYTHONPATH=. python ./wantedpages/tests/__init__.py

It should be simple to add test cases for any issues you fix, but if you run into trouble please feel free to CC me on the ticket. The cases in which you need to provide a particular context can be slightly more complex.

comment:9 Changed 4 years ago by Justin Francis

Hi Guys, I give my blessing for someone to take over maintenance of this project. Being absent for, oh, 2-3 years does not make for a great maintainer. Good luck

comment:10 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: newclosed

glinders is now the maintainer. Please complete the steps at AdoptingHacks#AfterAdoptingaHack.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Justin Francis.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.