Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10897 closed enhancement (fixed)

Drop-down style menus don't work under Agilo: easy fix

Reported by: jmlvargas@… Owned by: Jun Omae
Priority: normal Component: TracWysiwygPlugin
Severity: normal Keywords: agilo
Cc: Trac Release: 0.12

Description

Drop-down style menus (style, TT and table) don't work under Agilo.

Agilo and this plugin both define a ".menu" css style, causing an style conflict. Changing the wysiwyg ".menu" style to something like ".wysiwyg-drop-menu" saves the day. Here is my patch file (review it before applaying).

Attachments (1)

diff.diff (1.3 KB) - added by jmlvargas@… 11 years ago.
Easy fix for drop down style menus for wysiwyg + agilo.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by jmlvargas@…

Attachment: diff.diff added

Easy fix for drop down style menus for wysiwyg + agilo.

comment:1 Changed 11 years ago by anonymous

Trac Release: 0.12

comment:2 Changed 11 years ago by Jun Omae

Status: newassigned

Looks good. It would be robust to such conflicts. Thanks.

comment:3 Changed 11 years ago by Jun Omae

Type: defectenhancement

Also, Agilo should not define .menu as top level in stylesheet. Are you send the same report to Agilo developers?

comment:4 in reply to:  3 ; Changed 11 years ago by anonymous

Replying to jun66j5:

Also, Agilo should not define .menu as top level in stylesheet. Are you send the same report to Agilo developers?

No, I didn't. Have you ever seen an Agilo's css? ;)

comment:5 Changed 11 years ago by Jun Omae

Resolution: fixed
Status: assignedclosed

(In [12680]) tracwysiwyg: removed .menu style from drop-down menu to avoid stylesheet conflicts with Agilo (fixed #10897)

Initial patch by jmlvargas@…. Thanks.

comment:6 in reply to:  4 Changed 11 years ago by Jun Omae

Replying to anonymous:

No, I didn't. Have you ever seen an Agilo's css? ;)

Yes. .menu is defined in http://demo.agilofortrac.com/chrome/agilo/stylesheet/agilo_theme.css.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.