Modify

Opened 5 years ago

Closed 5 years ago

#11035 closed defect (worksforme)

mysql-specific SQL [patch]

Reported by: Marc Olzheim Owned by: Andreas
Priority: normal Component: ProjectPlanPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The ppreport code contains 3 mysql-specific parts which can easily be made generic.

Attaching patch.

Attachments (1)

sql-limit-fix.patch (1.7 KB) - added by Marc Olzheim 5 years ago.
SQL portability patch

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by Marc Olzheim

Attachment: sql-limit-fix.patch added

SQL portability patch

comment:1 Changed 5 years ago by Ryan J Ollos

Owner: changed from Matthias to Andreas

I changed the Component owner just now so that new tickets will be assigned to anbo (current maintainer).

comment:2 Changed 5 years ago by Ryan J Ollos

The Trac database API should be utilized according to t:TracDev/DatabaseApi#RulesforDBAPIUsage. String formatting should not be used to pass arguments to SQL statements, as it will cause cross-DB compatibility issues.

comment:3 Changed 5 years ago by Andreas

(In [13069]) v1.1.2, patch release

solved the MySQL specific issues, refs #11035

thanks to marc@your.tv for the patch

comment:4 Changed 5 years ago by anonymous

Resolution: worksforme
Status: newclosed

I changed the queries as the patch implied.

Changing all the SQL queries is not as easy. However, thanks to rjollos for making the constraints clear.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Andreas.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.