Modify ↓

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#11036 closed enhancement (fixed)

Use Option class for defining options

Reported by: Ryan J Ollos Owned by: Graham Miln
Priority: normal Component: MilnCheckboxPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Cool plugin! I have a minor suggested improvement, which can be found in the attached patch.

If you use the Option class, and provide documentation, it will display on the TracIni page:

The patch also fixes a few ​PEP8 violations.

Attachments (2)

TracIni.png​ (15.7 KB) - added by Ryan J Ollos 13 years ago.
t11036.diff​ (1.7 KB) - added by Ryan J Ollos 13 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by Ryan J Ollos

Reporter: changed from anonymous to Ryan J Ollos

Changed 13 years ago by Ryan J Ollos

Attachment: TracIni.png​ added

Changed 13 years ago by Ryan J Ollos

Attachment: t11036.diff​ added

comment:2 Changed 13 years ago by Ryan J Ollos

Btw, the patch is not quite complete. The placeholders Put some documentation here need to be replaced with real documentation.

comment:3 Changed 13 years ago by Graham Miln

Status: new → assigned

comment:4 Changed 13 years ago by Graham Miln

Resolution: → fixed
Status: assigned → closed

Thank you for the patch; I appreciate your looking over the code.

Fixed in r13008.

comment:5 Changed 13 years ago by Ryan J Ollos

Sure, no problem. I might have a few other suggestions related to how the markup strings are generated. I'll see if I can find time to take another look.

Have you been working with Trac and Python for long? I'm always curious as to how people are using Trac, particularly plugin authors.

Hint: You can use ​t:CommitTicketUpdater to have commit messages inserted into ticket. For example, add Refs #11036 or Fixes #11036 in your commit message. You can see some examples in various tickets, such as #10218.

comment:6 Changed 12 years ago by Graham Miln

Thank you. I have responded via e-mail to your questions.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Graham Miln.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.