Get more appropriate resource ID from rendering context

[Steffen Hoffmann]

VoteList has an issue when included into a milestone description, but executed in /roadmap context, where it will show all recent votes instead of just these for the corresponding milestone.

While the root cause obviously is the inability to retrieve a valid resource ID (roadmap itself is not vote-able yet for the same reason), a backwards-compatible fix is not trivial, but certainly required.

[Steffen Hoffmann]

From previous work for BreadCrumbsNavPlugin I remember, that there are at least two, if not three different ways to get a resource ID from rendering context.

I'll have to dig that out again, and will very likely lift valuable code and inspiration for that plugin from here as well. Like with BookmarkPlugin there are some amazing similarities.

[Ryan J Ollos]

Feel free to push ahead now that 0.2.0 and 0.3.0 have been released.

[Ryan J Ollos]

A related issue revealed in #12595 is that the parent resource is not extracted from the path, needed for realms such as changeset.

[Ryan J Ollos]

I think it was mentioned elsewhere, it would be nice to backport resource_from_path to Trac.

[Ryan J Ollos]

Replying to Ryan J Ollos:

I think it was mentioned elsewhere, it would be nice to backport resource_from_path to Trac.

=> ​trac:#12813.

[Jun Omae]

I think we should use data['context'].resource in post_process_request() rather than resource_from_path which is detecting resource from path.

See attachment:t11073.diff​.

Another issue, attachment and changeset resources are not supported since missing parent realm and id in votes table.

[Ryan J Ollos]

In 16916:

TracVote 0.7.0dev: Make tests pass with Trac 1.0-stable and trunk

Refs #11073.

[Ryan J Ollos]

In 16917:

TracVote 0.7.0dev: Remove unused import and bump version

Refs #11073.

[Ryan J Ollos]

t11073.diff​ looks good to me. Please commit.

[Jun Omae]

In 16918:

TracVote 0.7.0dev: use assertEqual(None, ...) instead of assertIsNone to make compatible with Python 2.5

Refs #11073.

[Jun Omae]

In 16919:

TracVote 0.7.0dev: fix comparing version strings in unit tests

Refs #11073.

[Jun Omae]

In 16920:

TracVote 0.7.0dev: retrieve resource object from rendering context

Fix #11073.

[Jun Omae]

Thanks for the review! Committed several changes and the patch.

[Ryan J Ollos]

In 16921:

TracVote 0.7.0dev: Make compatible with Trac 1.3.2+ (Jinja2)

Refs #11073.

[Ryan J Ollos]

Additional inspired changes: t11073.1.diff​.

[Ryan J Ollos]

In 16922:

TracVote 0.7.0dev: Avoid using $ at global scope

Refs #11073.

[Ryan J Ollos]

Replying to Ryan J Ollos:

A related issue revealed in #12595 is that the parent resource is not extracted from the path, needed for realms such as changeset.

Replying to Jun Omae:

Another issue, attachment and changeset resources are not supported since missing parent realm and id in votes table.

=> #13315.

[Jun Omae]

Replying to Ryan J Ollos:

Additional inspired changes: t11073.1.diff​.

Looks good to me.

[Ryan J Ollos]

In 16933:

TracVote 0.7.0dev: Refactor to use resource from context

Follow-on to r16920. Thanks to Jun Omae for review.

Refs #11073.