Modify

Opened 4 years ago

Last modified 3 months ago

#11073 new defect

Get more appropriate resource ID from rendering context

Reported by: Steffen Hoffmann Owned by:
Priority: normal Component: VotePlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann Trac Release:

Description

VoteList has an issue when included into a milestone description, but executed in /roadmap context, where it will show all recent votes instead of just these for the corresponding milestone.

While the root cause obviously is the inability to retrieve a valid resource ID (roadmap itself is not vote-able yet for the same reason), a backwards-compatible fix is not trivial, but certainly required.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by Steffen Hoffmann

From previous work for BreadCrumbsNavPlugin I remember, that there are at least two, if not three different ways to get a resource ID from rendering context.

I'll have to dig that out again, and will very likely lift valuable code and inspiration for that plugin from here as well. Like with BookmarkPlugin there are some amazing similarities.

comment:2 Changed 2 years ago by Ryan J Ollos

Owner: Ryan J Ollos deleted

Feel free to push ahead now that 0.2.0 and 0.3.0 have been released.

comment:3 Changed 21 months ago by Ryan J Ollos

A related issue revealed in #12595 is that the parent resource is not extracted from the path, needed for realms such as changeset.

comment:4 Changed 21 months ago by Ryan J Ollos

I think it was mentioned elsewhere, it would be nice to backport resource_from_path to Trac.

comment:5 in reply to:  4 Changed 3 months ago by Ryan J Ollos

Replying to Ryan J Ollos:

I think it was mentioned elsewhere, it would be nice to backport resource_from_path to Trac.

=> trac:#12813.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.