Modify ↓
Opened 11 years ago
Closed 9 years ago
#11163 closed defect (fixed)
Code review disappears after making a comment
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | normal | Component: | CodeReviewerPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 1.0 |
Description
I've encountered a problem where the code review plugin stops working after submitting a comment in the changeset. Changing status works fine, just when adding a comment the possibility to view or change comments and status in the changeset view disappears.
The status is still visible in the ticket if a commit reference to the ticket is given.
I have tested this on a win7 machine + firefox and internet explorer.
Attachments (0)
Change History (7)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
It is always before \n so it is probably windows adding a \r before \n when submitting the form and then it is not stringified.
comment:3 Changed 9 years ago by
Owner: | changed from Rob Guttman to Ryan J Ollos |
---|---|
Status: | new → accepted |
Note: See
TracTickets for help on using
tickets.
Some additional info + a solution that works for me:
When I look at the source code of the web site when I am in a changeset where the plugin has stopped working and looking in the generated
coderev.html
by navigating fromthe comment (hello world) has some linebreaks that seems to be the problem:
If I make the following change to
model.py
:I get instead in
coderev.html
:and now the plugin works!
I dont know if this is a problem with my browser or that I'm on a windows machine but with the fix in
model.py
it works.