#11164 closed enhancement (fixed)
Package site templates after porting from ClearSilver to Genshi
Reported by: | Ryan J Ollos | Owned by: | Ryan J Ollos |
---|---|---|---|
Priority: | normal | Component: | TracHacksPlugin |
Severity: | normal | Keywords: | clearsilver genshi templates |
Cc: | Steffen Hoffmann, osimons | Trac Release: |
Description (last modified by )
As osimons mentioned in comment:45:ticket:10193, the site templates need to be ported from ClearSilver to Genshi. I'll suggest that it makes sense to have TracHacksPlugin install the templates so that they'll be maintained in source control, versioned and installed as part of the package.
Attachments (0)
Change History (17)
comment:2 Changed 11 years ago by
I had been thinking about looking at making a theme that worked with ThemeEnginePlugin, but haven't investigated enough to form any opinion about what would work best, all things considered. Which way would you implement it?
comment:3 Changed 11 years ago by
Status: | new → assigned |
---|
comment:4 follow-up: 14 Changed 11 years ago by
I don't know TracHacksPlugin or ThemeEnginePlugin, and find that writing streamfilters is pain if I don't first have working template code to 'convert'. So site.html
is by far the easiest to write and maintain for me.
However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial py:match
directives to streamfilters.
comment:5 Changed 11 years ago by
Summary: | Port site templates from ClearSilver to Genshi → Package site templates after porting from ClearSilver to Genshi |
---|
comment:6 Changed 11 years ago by
Images from server were captured in [13510], see comment:98:ticket:10193.
comment:9 Changed 10 years ago by
[14484-14485] was committed by me. I didn't realize before the commit that the SVN credentials for otaku42 are cached on the server.
comment:11 Changed 10 years ago by
Type: | defect → enhancement |
---|
comment:12 Changed 10 years ago by
Status: | assigned → accepted |
---|
comment:13 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:14 Changed 10 years ago by
Replying to osimons:
However, I've looked over the earlier templates customizations, and I cannot find more things missing? All I've done is add support for the stylesheet + new ticket text, so any further customization must be part of some plugin code. And if you want it all in a plugin, it should be easy to convert these two trivial
py:match
directives to streamfilters.
I think that all of the styling has been restored, but please let me know if you find anything else missing.
In absence of any additional findings, the last step for this ticket will be to move the template code in site.html
to TracHacksPlugin.
comment:17 Changed 9 years ago by
Changes have been deployed to https://bobcat.edgewall.com for testing.
Or redo changes as streamfilters. Or redo them as a theme that includes the directives as part of layout.