Modify

Opened 4 years ago

Last modified 4 months ago

#11179 new defect

[Patch] Milestones on versions page are not shown in 0.12/trunk & /versions not working

Reported by: AlexK Owned by:
Priority: highest Component: ExtendedVersionPlugin
Severity: major Keywords:
Cc: Trac Release: 1.0

Description

When the patch I wrote was applied 2 years ago, the whole "show milestones underneath each version" feature was only applied to the 0.11 folder but not 0.12. Therefore this feature is no longer part of trunk!

Attachments (4)

roadmap.diff (10.2 KB) - added by AlexK 4 years ago.
Fixes roadmap version view and regex bug
roadmap.2.diff (10.1 KB) - added by AlexK 4 years ago.
Corrected version
roadmap.3.diff (10.4 KB) - added by AlexK 4 years ago.
Previous patch plus removed ul/li marker in roadmap view
roadmap4.diff (15.5 KB) - added by AlexK 8 months ago.
Adaptions for Trac 1.2 and re-integrated the progress bars on the version overview page

Download all attachments as: .zip

Change History (13)

comment:1 Changed 4 years ago by Ryan J Ollos

Are you referring to [10468] / #7620?

Changed 4 years ago by AlexK

Attachment: roadmap.diff added

Fixes roadmap version view and regex bug

comment:2 Changed 4 years ago by AlexK

Priority: highhighest
Summary: Milestones on versions page are not shown in 0.12/trunk[Patch] Milestones on versions page are not shown in 0.12/trunk & /versions not working

Patch fixes milestones to be available in version view again, adapted for trac 1.0 CSS style. Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

comment:3 Changed 4 years ago by anonymous

Oops, had a bug due to incorrect indention in the first version of the patch.

Changed 4 years ago by AlexK

Attachment: roadmap.2.diff added

Corrected version

Changed 4 years ago by AlexK

Attachment: roadmap.3.diff added

Previous patch plus removed ul/li marker in roadmap view

comment:4 Changed 4 years ago by Ryan J Ollos

Status: newassigned

I probably won't get to this for a few days, but it's in my near-term work plan.

comment:5 in reply to:  2 Changed 4 years ago by Ryan J Ollos

Replying to AlexK:

Also fixes an infinite recursion caused by incorrect regex in versions.py when trying to view /versions as it was incorrectly matched here (caused by previous commit that tried to fix new version page not matched).

I haven't successfully reproduced the infinite recursion issue, however I confirm that the regex doesn't work as intended. I setup some tests and modified the regex. The previous commit that caused the issue was [12231].

As for the rest of the changes, they'll take me a while to sort through. If you were to break up this up into a series of patches representing concise changes, that would speed up the process.

comment:6 Changed 4 years ago by Ryan J Ollos

In 13341:

Added unit test harness and failing unit test for VisibleVersion.match_request. Refs #11179.

comment:7 Changed 4 years ago by Ryan J Ollos

In 13342:

Fixed regression from [12231]. Refs #10354, #11179.

VisibleVersion.match_request should not return True for the path /versions.

Changed 8 months ago by AlexK

Attachment: roadmap4.diff added

Adaptions for Trac 1.2 and re-integrated the progress bars on the version overview page

comment:8 Changed 8 months ago by Ryan J Ollos

Status: assignedaccepted

comment:9 Changed 4 months ago by Ryan J Ollos

Owner: Ryan J Ollos deleted
Status: acceptednew

@AlexK: Would you consider rebasing your changes on the trunk again? There were some major changes in r16610 to adapt to the Trac 1.0 database API. If you revise the patch I'll commit it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.