Modify ↓
Opened 12 years ago
Closed 9 years ago
#11213 closed defect (fixed)
The username input doesn't have focus when the page loads
| Reported by: | Ryan J Ollos | Owned by: | Steffen Hoffmann |
|---|---|---|---|
| Priority: | normal | Component: | AccountManagerPlugin |
| Severity: | minor | Keywords: | |
| Cc: | Trac Release: | 0.11 |
Description (last modified by )
Tested with Trac 0.11 and Trac 1.0.2. The focus is placed on the #username input in 0.11, but not in Trac 1.0.2. The patch that follows has been tested in both Trac 0.11 and 1.0.2 and works correctly for both cases.
Attachments (1)
Change History (10)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
Changed 12 years ago by
| Attachment: | t11213.diff added |
|---|
comment:2 Changed 12 years ago by
The /reset_password page has the same issue, and we should set the focus on #old_password_chg when navigating to /prefs/account.
comment:4 Changed 12 years ago by
Replying to rjollos:
... has been tested in both Trac 0.11 and 1.0.2 and works correctly for both cases.
Thank you very much for taking care.
comment:5 Changed 12 years ago by
I'm not seeing that this causes a problem, but for consistency we might want to remove the [0] on the two remaining instances:
user@ubuntu:~/Workspace/trachacks.git$ grep -R "\[0\].focus()" accountmanagerplugin/trunk accountmanagerplugin/trunk/acct_mgr/templates/verify_email.html: $('#token')[0].focus(); accountmanagerplugin/trunk/acct_mgr/templates/login.html: $('#username')[0].focus();
comment:6 Changed 11 years ago by
| Status: | new → accepted |
|---|
comment:7 Changed 11 years ago by
| Trac Release: | → 0.11 |
|---|
comment:9 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Note: See
TracTickets for help on using
tickets.



Patch against r13290 of the trunk.