Modify ↓

Opened 12 years ago

Closed 7 years ago

#11214 closed enhancement (fixed)

Rename db_cleanup to admin_db_cleanup

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

All of the templates for the admin realm are prefixed with admin_, with the exception of db_cleanup.html. Would it make sense to rename db_cleanup.html to admin_db_cleanup.html?

Attachments (0)

Change History (7)

comment:1 Changed 12 years ago by Steffen Hoffmann

In 13324:

AccountManagerPlugin: Finally unify admin panel template names after [13054], refs #11214.

comment:2 Changed 12 years ago by Ryan J Ollos

Thanks, it makes organizing the template map in ThemeEnginePlugin a bit easier.

comment:3 Changed 12 years ago by Jun Omae

I think that it should be a unique template name, e.g. admin_accounts_db_cleanup.html, acct_mgr_admin_db_cleanup.html, etc....

comment:4 in reply to:  3 Changed 12 years ago by Ryan J Ollos

Replying to jun66j5:

I think that it should be a unique template name, ...

Seems like a good best practice, to prefix templates with the plugin name. I'll keep it in mind for other plugins.

comment:5 Changed 9 years ago by Ryan J Ollos

Owner: Steffen Hoffmann deleted

comment:6 Changed 7 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: new → accepted

comment:7 Changed 7 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 17223:

TracAccountManager 0.5.1: Use common template name prefix

Fixes #11214.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.