Cannot hide "hours" main nav

[Jared]

This is a great plugin. Currently in trac 1.0.1 I am unable to hide the "hours" tab from users who DO NOT have the TICKET_ADD_HOURS permissions. Can you please advise on an effective method to do so?

[Ryan J Ollos]

It looks like we aren't doing the necessary permission checks in the INavigationContributor implementation​. It will be straightforward to fix. Could I interest you in generating a patch?

[Jared]

If I were that technically inclined I would, but unfortunately I am not. Please however do let me know how I may be able to assist.

[Ryan J Ollos]

I'll try to get this fixed today.

[Jared]

Any updates? Please let me know if I can be of assistance.

[Ryan J Ollos]

I think what we really need is a TICKET_VIEW_HOURS permission. If the user doesn't have TICKET_ADD_HOURS, they may still want the ability to view hours. I'll have to take a closer look though.

[Jared]

Precisely. I think that approach is a lot more useful and logical. Our current Trac instance serves program developers, end users and project managers.. Permissions such as you have suggested are key.

[Ryan J Ollos]

Thanks for the feedback. I'm planning to finish up this ticket on the coming Saturday. I'll let you know if anything changes with regard to that.

[anonymous]

Hi there. Any status updates?

[Ryan J Ollos]

I didn't get to this last weekend, though it's on my list for the coming weekend (along with #11275).

[Ryan J Ollos]

In 13356:

Require TICKET_VIEW_HOURS to access the path /hours. Refs #11252.

[Ryan J Ollos]

In 13357:

Fixed missing linebreak. Refs #11252.

[Ryan J Ollos]

In 13358:

Removed unnecessary permission check. Refs #11252.

[Ryan J Ollos]

I didn't have much time to spend on this, which partially accounts for the sloppiness of [13356-13358]. The changes could benefit from additional testing. Please report back if you can.

[Jared]

The changes work perfectly. Thank you for implementing the new permission set and being so responsive to the feedback.