Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#11480 closed defect (fixed)

Documentation for "filter" not present on TracIni page

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Component: SumStatsPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

The documentation should be as shown in sumstatsplugin/0.12/sumstats/web_ui.py@13548:31-32#L23. However, the following is seen:

Attachments (2)

TracIni.png (24.1 KB) - added by Ryan J Ollos 3 years ago.
sumstatsplugin-r13548.diff (1.3 KB) - added by Jun Omae 3 years ago.

Download all attachments as: .zip

Change History (6)

Changed 3 years ago by Ryan J Ollos

Attachment: TracIni.png added

Changed 3 years ago by Jun Omae

Attachment: sumstatsplugin-r13548.diff added

comment:1 Changed 3 years ago by Jun Omae

The field and filter options are defined twice. Proposed patch, sumstatsplugin-r13548.diff, is to remove it. After the patch, it would be fixed.

comment:2 Changed 3 years ago by Ryan J Ollos

Thanks, feel free to commit it (robguttman confirmed in comment:6:ticket:11118). Would we want to use self.env.config.get('sumstats', 'field') rather than SumTicketGroupStatsProvider(self.env).sum_field?

comment:3 Changed 3 years ago by Jun Omae

Resolution: fixed
Status: newclosed

In 13559:

Removed duplicated definitions of option to fix hidden documentation for filter on TracIni macro (fixed #11480)

comment:4 in reply to:  2 Changed 3 years ago by Jun Omae

Owner: changed from Rob Guttman to Jun Omae
Summary: Documentation for "filters" not present on TracIni pageDocumentation for "filter" not present on TracIni page

Thanks, feel free to commit it (robguttman confirmed in comment:6:ticket:11118). Would we want to use self.env.config.get('sumstats', 'field') rather than SumTicketGroupStatsProvider(self.env).sum_field?

Okay. Committed the patch using self.config.get('sumstats', ...).

Modify Ticket

Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.