Modify ↓

Opened 10 years ago

Closed 8 years ago

#11607 closed defect (fixed)

Processing "View revision" needs "display_rev" set in data.

Reported by: anonymous Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release:

Description

When creating a code review, the browser display can show files based on a revision in the "View revision" field.

When setting this field, the display_rev property needs to be set when calling the web page. (I am not entirely familiar with programming of the templates and such, but I hope this is making sense.)

I seem to have fixed this in my own installation (Trac 0.12.2) by inserting some lines in file peerReviewBrowser.py, function process_request() ...

First, after the retrieving of repos, I added: 

        display_rev = repos.display_rev

Then when setting data, I added: 

            'display_rev': display_rev,

Attachments (0)

Change History (2)

comment:1 Changed 8 years ago by Cinc-th

Owner: changed from Olemis Lang to Cinc-th
Status: new → assigned

comment:2 Changed 8 years ago by Cinc-th

Resolution: → fixed
Status: assigned → closed

In 15158:

Add 'display_rev' to data needed by file browser.

Fixes #11607

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.