Modify

Opened 3 years ago

Closed 4 months ago

Last modified 4 months ago

#11632 closed enhancement (fixed)

Simplify code by using add_script_data

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: QueuesPlugin
Severity: normal Keywords:
Cc: Justin Ludwig Trac Release:

Description

We can simplify the code quite a bit by removing the Genshi markup from the JavaScript template, moving the file from templates to htdocs and using add_script_data to pass the variables.

Also, I think the plugin doesn't currently work with Trac 1.0. It seemed to be working fine in 0.12, but when I switched branches the re-ordering would no longer be saved. I didn't see any errors in the console, but didn't dig any deeper into the issue.

Attachments (0)

Change History (5)

comment:1 Changed 4 months ago by Ryan J Ollos

Cc: Justin Ludwig added

comment:2 Changed 4 months ago by Ryan J Ollos

Owner: changed from Rob Guttman to Ryan J Ollos
Status: newaccepted

comment:3 Changed 4 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 15979:

1.2.0dev: Replace virtual script by using add_script_data

Fixes #11632.

comment:4 Changed 4 months ago by Ryan J Ollos

@justinludwig: I implemented this pretty quickly. It seems to be working well, but please report back if you are able to do more testing. You'll need to install from queuesplugin/1.2.

comment:5 in reply to:  4 Changed 4 months ago by Justin Ludwig

I tried out the latest from the queuesplugin/1.2 branch -- works great, thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.