Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#11759 closed defect (fixed)

Does not escape HTML for user name.

Reported by: uchida_t@… Owned by: uchida_t@…
Priority: normal Component: AutocompleteUsersPlugin
Severity: normal Keywords:
Cc: Steffen Hoffmann Trac Release:

Description

  1. Enter the user name ([Preferences] - [General] - [Full name]) to <script>alert(1)</script>.
  2. If autocompleted, alert.

This can use to XSS attack.

Attachments (1)

autocompleteusersplugin.patch (1.2 KB) - added by uchida_t@… 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by uchida_t@…

comment:1 Changed 3 years ago by Tetsuya Morimoto

It works for our trac-1.0.2dev.

comment:2 Changed 3 years ago by Ryan J Ollos

Status: newaccepted

comment:3 Changed 3 years ago by Ryan J Ollos

As far as I can tell we don't need the change to autocompleteusers/htdocs/js/autocomplete.js in autocompleteusersplugin.patch. The change to autocompleteusers/htdocs/js/format_item.js fixes the issue reported in comment:description. Please let me know if any issues can be reproduced after the forthcoming change.

comment:4 Changed 3 years ago by Ryan J Ollos

Summary: Do not escape HTML for user name.Does not escape HTML for user name.

comment:5 Changed 3 years ago by Ryan J Ollos

In 13962:

0.4.2dev: Escape HTML when formatting entries for autocompletion.

Patch by uchida_t@…. Refs #11759.

comment:6 Changed 3 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

comment:7 Changed 3 years ago by Ryan J Ollos

Cc: Steffen Hoffmann added; anonymous removed
Owner: changed from Ryan J Ollos to uchida_t@…

comment:8 Changed 3 years ago by uchida_t@…

Thank you! I confirmed that this has been fixed.

comment:9 Changed 3 years ago by Tetsuya Morimoto

In 14108:

Refs #11946: Backported escape functions for Trac-0.11 compatibility

  • Refs #11759: Reported by uchida_t-san

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain uchida_t@….
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.