Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11946 closed task (fixed)

Release version 0.4.2 as a checkpoint

Reported by: Tetsuya Morimoto Owned by: Tetsuya Morimoto
Priority: normal Component: AutocompleteUsersPlugin
Severity: normal Keywords:
Cc: Jun Omae, Ryan J Ollos Trac Release: 0.11

Description

According to #10172, 0.4.2 was supposed to include as follows.

However, I will release current trunk revision as 0.4.2. Because I'm new maintainer and I haven't known past background. So, this release is for comparison before I maintain AutocompleteUsers plugin.

In conclusion, 0.4.2 should include them.

Attachments (0)

Change History (24)

comment:1 Changed 10 years ago by Tetsuya Morimoto

typo:

correct:

comment:2 Changed 10 years ago by Tetsuya Morimoto

I made 0.4.2 pacakge, and then did a test on Trac-0.11. I got an error when I input text into Cc: field.

TypeError: $.htmlFormat is not a function
return $.htmlFormat('<div class="name">$1</div>', firstLine) +

comment:3 Changed 10 years ago by Tetsuya Morimoto

It comes from r13962 (#11759).

Last edited 10 years ago by Tetsuya Morimoto (previous) (diff)

comment:4 Changed 10 years ago by Tetsuya Morimoto

I could reproduced #11750 bug to set script code into Preference->General->Full name: with previous code.

Test User <script>alert('hi!');</script>
Last edited 10 years ago by Tetsuya Morimoto (previous) (diff)

comment:5 Changed 10 years ago by Ryan J Ollos

Since htmlFormat was not added to Trac until 0.12 ([trac 9822], trac:#9396), we could just copy the function to AutocompleteUsersPlugin and wrap the definition with if(!$.isFunction($.htmlFormat)), as in adminenumlistplugin/trunk/adminenumlistplugin/htdocs/adminenumlist.js@12644:13#L8.

comment:6 Changed 10 years ago by Tetsuya Morimoto

OK. I will try.

comment:8 Changed 10 years ago by Tetsuya Morimoto

Last edited 10 years ago by Tetsuya Morimoto (previous) (diff)

comment:9 Changed 10 years ago by Tetsuya Morimoto

I simply tested on Trac-0.11 and Trac-1.0.2. Both work for me.

comment:10 Changed 10 years ago by Ryan J Ollos

Yeah, that is what I had in mind. Looks good to me!

In case you weren't aware, there's a console.log in the changeset, but maybe you planned to remove that before committing to trunk.

comment:11 in reply to:  10 Changed 10 years ago by Tetsuya Morimoto

Replying to rjollos:

In case you weren't aware, there's a console.log in the changeset, but maybe you planned to remove that before committing to trunk.

Oh, thank you for commenting. I'm going to commit carefully :)

comment:12 Changed 10 years ago by Tetsuya Morimoto

In 14108:

Refs #11946: Backported escape functions for Trac-0.11 compatibility

  • Refs #11759: Reported by uchida_t-san

comment:13 Changed 10 years ago by Tetsuya Morimoto

comment:14 Changed 10 years ago by Tetsuya Morimoto

To release package to PyPI,

$ cd path/to/autocompleteusersplugin/trunk
$ python setup.py egg_info -RDb "" sdist register upload

Now, we can install from PyPI with pip like this.

$ pip install TracAutocompleteUsersPlugin

comment:15 Changed 10 years ago by Tetsuya Morimoto

to rjollos:

I will add you as a owner on PyPI if you have an account.

comment:16 Changed 10 years ago by Tetsuya Morimoto

In 14110:

Refs #11946: Created 0.4.2 branch (r14109)

comment:17 Changed 10 years ago by Tetsuya Morimoto

I had a typo commit message, 0.4.2-branch is created from r14109.

comment:18 Changed 10 years ago by Ryan J Ollos

It's not a huge deal, but the 0.4.2 branch and maybe the released package will have the version 0.4.2dev: autocompleteusersplugin/branches/0.4.2/setup.cfg@14111:2.

comment:19 Changed 10 years ago by Ryan J Ollos

Also, do we want to put that directory in tags rather than branches?

comment:20 Changed 10 years ago by Tetsuya Morimoto

I see. We should remove tag_build = dev on branches to install from source and maybe tags is better ...

Last edited 10 years ago by Tetsuya Morimoto (previous) (diff)

comment:21 Changed 10 years ago by Tetsuya Morimoto

In 14113:

Refs #11946: Moved branches to tags and removed tag_build

comment:22 Changed 10 years ago by Ryan J Ollos

Thanks, my account on PyPI uses my same username as here.

comment:23 Changed 10 years ago by Tetsuya Morimoto

Resolution: fixed
Status: newclosed

Thanks, done.

comment:24 in reply to:  17 Changed 10 years ago by Ryan J Ollos

Replying to t2y:

I had a typo commit message, 0.4.2-branch is created from r14109.

I edited your commit to reference r14109.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Tetsuya Morimoto.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.