Modify

Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#11913 closed defect (fixed)

[Patch] Conflicts with DynamicFieldsPlugin

Reported by: jojo Owned by: Ryan J Ollos
Priority: normal Component: SubcomponentsPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description (last modified by Ryan J Ollos)

please add feature about for "show_when_component"

Attachments (2)

t11913.patch (1.3 KB) - added by Ryan J Ollos 10 years ago.
t11913.2.patch (2.4 KB) - added by Ryan J Ollos 10 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 10 years ago by Ryan J Ollos

Have you tried it? I believe that the show_when_ will work for any field, even though there is not an explicit example given for the component field on the DynamicFieldsPlugin page.

comment:2 Changed 10 years ago by jojo

yes, my test case as following:

[ticket-custom]
test = select
test.label = Test
test.options = 1|2|3
test.order = 4
test.show_when_component= test
test.value =

the test field is invisible always :(

the show_when_type is useful in the same case...

BTW, my trac version is 1.0.1, and i test "DynamicFieldsPlugin" plugin 0.11 and 0.12 both, no one can set show_when_component.

Last edited 10 years ago by Ryan J Ollos (previous) (diff)

comment:3 Changed 10 years ago by Ryan J Ollos

Currently being discussed in gdiscussion:trac-users:8WMlZStFx-8.

comment:4 Changed 10 years ago by Rob Guttman

As Ryan indicated, the plugin should work for any standard and custom field.

Do any dynamic fields work? I ask because it may be that the plugin isn't installed correctly. You can check the Admin > Plugins section to make sure you see the plugin listed and enabled.

comment:5 Changed 10 years ago by jojo

it's really "conflicts" problem with another plugin named "http://hg.haiku-os.org/trac-subcomponents",

it's working now if i disable plugin "trac-subcomponents" :)

BTW, some field which is in the mail notification always visible even that is invisible in the "ticket system" of Trac

any solution for mail notification same as "ticket system" ?

comment:6 in reply to:  5 Changed 10 years ago by Ryan J Ollos

Replying to rjiejie:

BTW, some field which is in the mail notification always visible even that is invisible in the "ticket system" of Trac

any solution for mail notification same as "ticket system" ?

You might be able to change the notification email using a custom template. See trac:wiki:TracNotification#Customizingthee-mailcontent for more details.

comment:7 Changed 10 years ago by Ryan J Ollos

Component: DynamicFieldsPluginSubcomponentsPlugin
Owner: changed from Rob Guttman to Frau Boonekamp

The conflict between SubcomponentsPlugin and DynamicFieldsPlugin is due to replacement of the Component select with a hidden input field by SubcomponentsPlugin.

The patch attachment:t11913.patch should fix the issue.

Changed 10 years ago by Ryan J Ollos

Attachment: t11913.patch added

comment:8 Changed 10 years ago by jojo

thanks for you patch, it's working :)

comment:9 Changed 10 years ago by Rob Guttman

Ryan rocks!

comment:10 Changed 10 years ago by jojo

Hi, this patch will create another issue in the "custom query" of ticket with enabled plugin "SubcomponentsPlugin"

test case:

  • filter set only du to component "begins with | is | not",

the result of query will show all ticket except filter rules :(

please update patch to fix this issue

thanks again

comment:11 Changed 10 years ago by jojo

BTW, if i revert t11913.patch, the custom query about for "SubcomponentsPlugin" is working well

Changed 10 years ago by Ryan J Ollos

Attachment: t11913.2.patch added

comment:12 Changed 10 years ago by Ryan J Ollos

Thanks Rob!

Revised patch in attachment:t11913.2.patch. Tested on ticket, new ticket, query and batch modify forms.

comment:13 Changed 10 years ago by Ryan J Ollos

Description: modified (diff)
Summary: show_when_component[Patch] Conflicts with DynamicFieldsPlugin

comment:14 Changed 10 years ago by Ryan J Ollos

Type: enhancementdefect

comment:15 Changed 9 years ago by malaclypsedj@…

I have similar conflicts with DynamicFieldPlugin and SubComponentsPlugin:

[ticket-custom]
checkbox.set_to_true_when_component = MainComponent/SubComponent

Would that patch also work with set_to rule?

I am a absolutle newbie, can anyone tell me how i can test this patch?

Last edited 9 years ago by Ryan J Ollos (previous) (diff)

comment:16 Changed 8 years ago by Ryan J Ollos

Owner: changed from Frau Boonekamp to Ryan J Ollos
Status: newaccepted

comment:17 Changed 8 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 16410:

TracSubcomponents 1.2.2: Fix conflict with DynamicFieldsPlugin

Fixes #11913.

comment:18 Changed 8 years ago by Ryan J Ollos

In 16411:

TracSubcomponents 1.2.2dev: Revert unintentional change in r16410

Refs #11913.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.