RegistrationError cannot initialize on Python 2.4

[Jun Omae]

Unit tests fail with Trac 0.12.5 on Python 2.4. super() function only works for new-style classes. TracError class is not a new-style class on Python 2.4.

$ PYTHONPATH=. ~/venv/trac/0.12.5/bin/python acct_mgr/tests/__init__.py --skip-functional-tests
..........................................................E.EEE.EE.E..EE.
======================================================================
ERROR: test_check_error (acct_mgr.tests.register.DummyRegInspectorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jun66j5/src/accountmanagerplugin.git/acct_mgr/tests/register.py", line 90, in test_check_error
    self.check.validate_registration(self.req)
  File "/home/jun66j5/src/accountmanagerplugin.git/acct_mgr/tests/register.py", line 61, in validate_registration
    raise RegistrationError('Dummy check error')
  File "/home/jun66j5/src/accountmanagerplugin.git/acct_mgr/register.py", line 50, in __init__
    super(RegistrationError, self).__init__(message, title, show_traceback)
TypeError: super() argument 1 must be type, not classobj
....

----------------------------------------------------------------------
Ran 73 tests in 2.780s

FAILED (errors=9)

acct_mgr/register.py

@@ -47 +47 @@
         tb = 'show_traceback'
         # Care for the 2nd TracError standard keyword argument only.
         show_traceback = tb in kwargs and kwargs.pop(tb, False)
-        super(RegistrationError, self).__init__(message, title, show_traceback)
+        TracError.__init__(self, message, title, show_traceback)
         self.msg_args = args
 
 

[Steffen Hoffmann]

In 14273:

AccountManagerPlugin: Remove super() on TracError class for Python2.4 compatibility, refs #11991.

Thanks to Jun Omae, who not only reported corresponding (unit) test results
but provided a clear explanation and suggested the fix right away as well.