Move away from using TRAC_ADMIN

[Keluri]

I'd like to request that this plugin move away from using the rather vague 'TRAC_ADMIN' permission to something more specific, such as a custom 'WORKFLOW_ADMIN' permission.

I maintain a Trac installation where there's a group of users who have the ability to change project settings (for things like tickets, timelines, and the wiki), but not core settings (such as logging and user permissions). When installing this plugin, I had to modify the main class in web_ui.py to use a custom permission.

[Jun Omae]

I don't want to add a new permission. However, changing TRAC_ADMIN to TICKET_ADMIN is okay to me.

[Ryan J Ollos]

I think it is a good choice to not add more permissions. Anyone wanting more fine-grained access control can use TracFineGrainedPermissions.

[Ryan J Ollos]

Replying to rjollos:

I think it is a good choice to not add more permissions. Anyone wanting more fine-grained access control can use TracFineGrainedPermissions.

After closer look, some modifications appear to be needed to support TracFineGrainedPermissions: tracworkflowadminplugin/0.12/tracworkflowadmin/web_ui.py@14210:129,134#L126​. The changes needed are similar to comment:1:ticket:11826.

[Jun Omae]

In 14211:

tracworkflowadmin: allow fine-grained access to the workflow admin panel (refs #12014)

[Ryan J Ollos]

Replying to Jun Omae:

However, changing TRAC_ADMIN to TICKET_ADMIN is okay to me.

Using TICKET_ADMIN sounds good to me.

[Jun Omae]

In 17145:

tracworkflowadmin: use TICKET_ADMIN rather than TRAC_ADMIN (closes #12014)