Project deletion does not remove info from other database tables

[Cinc]

When deleting a project from the admin panel only self.__SmpModel.delete_project([id]) is called. The association of milestones to projects in database table smp_milestone_project isn't removed. Same is probably true for the version table.

[Cinc]

The following patch should do the job:

Requirements-Trac/Trac/Plugins/SimpleMultiProject-0.0.4dev-py2.7.egg/simplemultiproject/model.py

@@ -226 +226 @@
             for id in ids_projects:
                 query = """DELETE FROM smp_project WHERE id_project=%s"""
                 cursor.execute(query, [id])
+                query = """DELETE FROM smp_milestone_project WHERE id_project=%s;"""
+                cursor.execute(query, [id])
+                query = """DELETE FROM smp_version_project WHERE id_project=%s;"""
+                cursor.execute(query, [id])
+                query = """DELETE FROM smp_component_project WHERE id_project=%s;"""
+                cursor.execute(query, [id])
             self.__start_transaction(db)
+
         else:
             @with_transaction(self.env)
             def execute_sql_statement(db):
                 cursor = db.cursor()
                 for id in ids_projects:
                     query = """DELETE FROM smp_project WHERE id_project=%s"""
+                    cursor.execute(query, [id])
+                    query = """DELETE FROM smp_milestone_project WHERE id_project=%s;"""
+                    cursor.execute(query, [id])
+                    query = """DELETE FROM smp_version_project WHERE id_project=%s;"""
+                    cursor.execute(query, [id])
+                    query = """DELETE FROM smp_component_project WHERE id_project=%s;"""
                     cursor.execute(query, [id])
 
     def update_project(self, id, name, summary, description, closed, restrict):

[Cinc]

Patch: remove project info from other database tables.

[Cinc]

Complete file: remove project info from other database tables.

[falkb]

In 14358:

patch by Cinc fixes #12128, thanks a lot for this contribution!

[falkb]

Looked good, tested with 1.0 and 0.12. Thanks Cinc! Do you have any more plans?

[Cinc]

I'm currently looking into #11160. That is a really easy one. Almost done with it.

#10089 would be nice to have (project specific wiki pages) but that's quite complicated. There is a reason why Trac doesn't support multiproject out of the box.