Use of lstrip("field-") to attempt to remove the substring "field-" from front of string is erroneous

[gpoveda@…]

In the file web_ui.py on line 177 the code is:

trigger = req.args.get("trigger", "").lstrip("field-")

The intent here is to "strip" off the substring "field-" from the beginning of the "trigger" request argument value. However, what this call actually does is strip off any of the characters in the set 'f', 'i', 'e', 'l', 'd', and '-' from the beginning of the string until a character is encountered that is NOT in the set. Therefore, if the trigger field name begins with any of these characters in the set, those characters will also be stripped off. Eg. a field named 'location' will be passed as trigger 'field-location', but after the lstrip call, trigger is set to 'ocation' instead. So any fields whose names begin with the characters in the set will fail to work as a chained field.

[anonymous]

Perhaps something like the following will be more appropriate:

trigger = req.args.get("trigger", "").replace('field-','',1)

[Ryan J Ollos]

In 14691:

0.2dev: Properly left strip field- token. Fixes #12405.

[Ryan J Ollos]

I didn't have time to do any testing. Could you please confirm the fix?

[gpoveda@…]

Replying to rjollos:

I didn't have time to do any testing. Could you please confirm the fix?

This fix is working fine for me. Thanks for the quick turn around!