Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#12722 closed defect (fixed)

Escaped elements in notices/warnings from accountmanager

Reported by: Jun Omae Owned by: Ryan J Ollos
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (last modified by Jun Omae)

The same issue while has been fixed in [15371] still exists in other locations.

I think Markup(tag_(...)) and Markup(tag(...)) have this issue.

$ grep -rF 'Markup(tag_(' .
./acct_mgr/admin.py:                    add_notice(req, Markup(tag_(
./acct_mgr/admin.py:            add_warning(req, Markup(tag_(
./acct_mgr/admin.py:                add_warning(req, Markup(tag_(
./acct_mgr/admin.py:            add_warning(req, Markup(tag_(
./acct_mgr/web_ui.py:            add_notice(req, Markup(tag_(
$ grep -rF 'Markup(tag(' .
./acct_mgr/admin.py:                add_notice(req, Markup(tag(_("Successfully deleted:"),

Attachments (2)

20160402T214613.png (15.7 KB) - added by Jun Omae 5 years ago.
t12722.diff (22.0 KB) - added by Ryan J Ollos 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by Jun Omae

Attachment: 20160402T214613.png added

comment:1 Changed 5 years ago by Jun Omae

Description: modified (diff)

comment:2 Changed 5 years ago by Ryan J Ollos

Owner: changed from Steffen Hoffmann to Ryan J Ollos
Status: newaccepted

Changed 5 years ago by Ryan J Ollos

Attachment: t12722.diff added

comment:3 Changed 5 years ago by Ryan J Ollos

The attached patch is lightly tested.

I'm thinking to just target the next version to Trac 1.0+. Steffen isn't maintaining the plugin any longer and I hardly have much time to spend it. It will be bad for the community if Trac 1.2 is released and AcccountManagerPlugin doesn't work with it. Let me know what you think.

Feel free to commit any changes you like, and hopefully we can get AccountManagerPlugin 0.5 released soon.

comment:4 Changed 5 years ago by Ryan J Ollos

In 15454:

0.5dev: Remove unused imports

Refs #12722.

comment:5 Changed 5 years ago by Ryan J Ollos

In 15482:

0.5dev: Bump required Trac version to 1.0

Refs #12722.

comment:6 Changed 5 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 15491:

0.5dev: Fix escaped elements in notices and warnings

Fixes #12722.

comment:7 Changed 4 years ago by Ryan J Ollos

#12685 closed as a duplicate.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.