Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12732 closed defect (fixed)

Regression in [15460]

Reported by: Ryan J Ollos Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos Trac Release:

Description

I haven't tested, but I suspect [15460] has a regression for site running with a base_path other than /.

src="chrome/hw/images/plus.gif"

should be replaced with:

src="href.chrome('hw/images/plus.gif')"

href is passed to templates in the chrome data dictionary.

The problem is likely seen for a site running at http://hostname/trac, whereas a site running at http://hostname/ will probably work fine.

Attachments (0)

Change History (4)

comment:1 Changed 9 years ago by Cinc-th

You're correct that this introduced a regression. I tested some stuff using a fake base_url and later noticed some missing images. Thus the change.

comment:2 Changed 9 years ago by Cinc-th

Resolution: fixed
Status: newclosed

In 15461:

PeerReviewPlugin: fixed regression wrt links to comment images introduced with [15460].
Thanks to rjollos for spotting the problem.

Closes #12732

comment:3 Changed 9 years ago by Ryan J Ollos

In [15461], you don't need to pass href to the templates: 'href': self.env.href.

href is passed in the chrome data dictionary (see comment:description).

comment:4 Changed 9 years ago by Cinc-th

Yes, but in this case this is an internal template with a private data dict which is created just for populating the template with data.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.