Regression in [15460]

[Ryan J Ollos]

I haven't tested, but I suspect [15460] has a regression for site running with a base_path other than /.

src="chrome/hw/images/plus.gif"

should be replaced with:

src="href.chrome('hw/images/plus.gif')"

href is passed to templates in the ​chrome data dictionary.

The problem is likely seen for a site running at http://hostname/trac, whereas a site running at http://hostname/ will probably work fine.

[Cinc-th]

You're correct that this introduced a regression. I tested some stuff using a fake base_url and later noticed some missing images. Thus the change.

[Cinc-th]

In 15461:

PeerReviewPlugin: fixed regression wrt links to comment images introduced with [15460].
Thanks to rjollos for spotting the problem.

Closes #12732

[Ryan J Ollos]

In [15461], you don't need to pass href to the templates: 'href': self.env.href.

href is passed in the chrome data dictionary (see comment:description).

[Cinc-th]

Yes, but in this case this is an internal template with a private data dict which is created just for populating the template with data.