Modify ↓
#12732 closed defect (fixed)
Regression in [15460]
Reported by: | Ryan J Ollos | Owned by: | Cinc-th |
---|---|---|---|
Priority: | normal | Component: | PeerReviewPlugin |
Severity: | normal | Keywords: | |
Cc: | Ryan J Ollos | Trac Release: |
Description
I haven't tested, but I suspect [15460] has a regression for site running with a base_path
other than /
.
src="chrome/hw/images/plus.gif"
should be replaced with:
src="href.chrome('hw/images/plus.gif')"
href
is passed to templates in the chrome data dictionary.
The problem is likely seen for a site running at http://hostname/trac
, whereas a site running at http://hostname/
will probably work fine.
Attachments (0)
Change History (4)
comment:1 Changed 9 years ago by
comment:3 Changed 9 years ago by
In [15461], you don't need to pass href
to the templates: 'href': self.env.href
.
href
is passed in the chrome data dictionary (see comment:description).
comment:4 Changed 9 years ago by
Yes, but in this case this is an internal template with a private data dict which is created just for populating the template with data.
Note: See
TracTickets for help on using
tickets.
You're correct that this introduced a regression. I tested some stuff using a fake base_url and later noticed some missing images. Thus the change.