Modify

Opened 8 years ago

Closed 4 years ago

Last modified 4 years ago

#12803 closed enhancement (fixed)

Format the referrers as links too

Reported by: anonymous Owned by: Ryan J Ollos
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords: patch
Cc: wolph@… Trac Release:

Description (last modified by Ryan J Ollos)

By simply adding [[ and ]] to line 216 in macros.py: wantedpagesmacro/trunk/wantedpages/macro.py@14534#L216

All referrers will be shown as links.

                        _data = _data + "||[[%s]]" % _name

Attachments (0)

Change History (7)

comment:1 Changed 8 years ago by wolph

Cc: wolph@… added

comment:2 Changed 8 years ago by Ryan J Ollos

Description: modified (diff)
Type: defectenhancement

comment:3 Changed 8 years ago by jan.wystub@…

Wrapping [[ and ]] around the string results in triggering unwanted macros, e.g. [[TracIni]].
I suggest changing the %s to [\"%s\"] or even to [wiki:\"%s\"] in lines 210, 216 & 219 in macro.py would give the best result if the name of a wiki page contains spaces.

Now my question is:
How can I help to patch the repository of the plugin so that installing can be achieved without locally editing the files next time? ;)

comment:4 Changed 4 years ago by figaro

Keywords: patch added

comment:5 in reply to:  3 Changed 4 years ago by Ryan J Ollos

Owner: changed from Geert to Ryan J Ollos
Status: newaccepted

Replying to jan.wystub@…:

Now my question is:
How can I help to patch the repository of the plugin so that installing can be achieved without locally editing the files next time? ;)

Sorry for the delay. See AdoptingHacks.

comment:6 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 17745:

TracWantedPages 0.6dev: Format referrers as TracLinks

Avoid expanding wanted pages as macros.

Fixes #12803.

comment:7 Changed 4 years ago by Ryan J Ollos

In 17887:

TracWantedPages 0.6: Publish version 0.6

Version 0.6 is r17745.

Bump trunk to 0.7.0dev.

Refs #13913, #13860, #12803.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.