Modify

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#12853 closed defect (fixed)

Trac 1.1+ requires dropping macros.html

Reported by: lkraav Owned by: Russ Tyndall
Priority: normal Component: TimingAndEstimationPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description (last modified by Ryan J Ollos)

/billing crashes on current trunk.

Because of timingandestimationplugin/branches/trac1.0/timingandestimationplugin/templates/billing.html#L8

Which is logical, considering r12889.

Just removing xi:include macros.html seems to work, but being a new user, I'm not sure what side-effects this might have.

Attachments (0)

Change History (13)

comment:1 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 5 years ago by Ryan J Ollos

I don't see any macros from macros.html used in billing.html, so it appears the include can just be deleted (and also from any other templates where it is used).

comment:3 Changed 5 years ago by Russ Tyndall

I have been quite busy this year as my company recently lost a valuable employee. I will try to get to this soon :)

comment:4 Changed 5 years ago by anonymous

Hello, is there any progress on this? I'm curious since distributions are moving to more modern trac and having billing.html not working is kind of pity. From my own experience the plugin has worked well on OpenBSD up to 6.0. Now, on 6.1 which distributes trac-1.2 it does not work anymore. If the plan is not to release some solution in the near future, is it at least possible to describe some easy workaround for this? For example I've tried manually edit all the billing.html files I'm able to find out on my system, but this does not help as it looks like billing.html itself is generated from something else (egg file?). So a way how to fix it at least locally would be appreciated here. Thanks! Karel

comment:5 Changed 5 years ago by Ryan J Ollos

I'd be happy to test and push the fix if it's acceptable to the plugin author.

comment:6 Changed 5 years ago by Russ Tyndall

Sorry, I lost track of this in the blur of my other duties :) I will get a patch tested and published today. There are some other outstanding tickets related to trac moving forward as well, so hitting it all at once makes sense to me.

Sorry for the delay, and thanks Ryan for the offer of assistance.

comment:7 Changed 5 years ago by Russ Tyndall

In 16683:

Remove defunct unused macros include in billing

re #12853

comment:8 Changed 5 years ago by Russ Tyndall

Also Ryan J Ollos (rjollos) :

For future reference, you have my permission to make patches against any of my repositories for the good of ensuring continued compatibility. I will continue to try and provide support. At this point though I am something like 11 (2006ish) years into trac and most of the ego attachments I might have had to this code are gone and I would love for it to continue to work with or without my current attention.

Thanks again for your continued support and thanks to lkraav for the bug reports!

Cheers, Russ Tyndall

comment:9 Changed 5 years ago by Russ Tyndall

Resolution: fixed
Status: newclosed

comment:10 Changed 5 years ago by Russ Tyndall

In 16688:

Porting changes from the non permission branch

  • Remove defunct, unused macros include in billing.html re #12853
  • Update database access for proper trac 1.1 Thanks lkraav re #13080
  • be more forgiving about what goes through convert float in ticket daemon re #13219
  • Change billing html a bit re #11280

comment:11 Changed 5 years ago by Ryan J Ollos

Thanks Russ!

comment:12 in reply to:  10 Changed 5 years ago by dave.anderson@…

Replying to Russ Tyndall:

16688 has not removed xi:include macros.html as per 16683 so #12853 is not yet resolved for the permissions branch.

comment:13 Changed 5 years ago by Russ Tyndall

Sorry just removed it in 16842

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Russ Tyndall.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.