Modify

Opened 7 years ago

Last modified 7 years ago

#12923 new enhancement

Fix for uppercase issue with Menus plugin

Reported by: ntmlod Owned by: Cinc-th
Priority: low Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

Not a clever one but it was essential for us to be able to move the navigation item.

  • codereview/peerReviewMain.py

     
    8585    # INavigationContributor methods
    8686
    8787    def get_active_navigation_item(self, req):
    88         return 'peerReviewMain'
     88        return 'peerreviewmain'
    8989
    9090    def get_navigation_items(self, req):
    9191        if 'CODE_REVIEW_DEV' in req.perm:
    92             yield ('mainnav', 'peerReviewMain',
    93                    Markup('<a href="%s">Peer Review</a>') % req.href.peerReviewMain())
     92            yield ('mainnav', 'peerreviewmain',
     93                   Markup('<a href="%s">Peer Review</a>') % req.href.peerreviewmain())
    9494
    9595    # IPermissionRequestor methods
    9696
     
    128128
    129129
    130130    def match_request(self, req):
    131         return req.path_info == '/peerReviewMain' or req.path_info == "/preview_render"
     131        return req.path_info == '/peerreviewmain' or req.path_info == "/preview_render"
    132132
    133133    def process_request(self, req):
    134134        req.perm.require('CODE_REVIEW_DEV')

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by Cinc-th

Priority: normallow

Glad to hear that fixed your problem. Not sure if you may run into other problems though because mixed case is sprinkled all over the source.

Anyway in the long run the names will become all lower case. That's on the Todo list.

Keeping this ticket open as a reminder.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Cinc-th.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.