Modify ↓
Opened 8 years ago
Last modified 8 years ago
#12923 new enhancement
Fix for uppercase issue with Menus plugin
Reported by: | ntmlod | Owned by: | Cinc-th |
---|---|---|---|
Priority: | low | Component: | PeerReviewPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 1.0 |
Description
Not a clever one but it was essential for us to be able to move the navigation item.
-
codereview/peerReviewMain.py
85 85 # INavigationContributor methods 86 86 87 87 def get_active_navigation_item(self, req): 88 return 'peer ReviewMain'88 return 'peerreviewmain' 89 89 90 90 def get_navigation_items(self, req): 91 91 if 'CODE_REVIEW_DEV' in req.perm: 92 yield ('mainnav', 'peer ReviewMain',93 Markup('<a href="%s">Peer Review</a>') % req.href.peer ReviewMain())92 yield ('mainnav', 'peerreviewmain', 93 Markup('<a href="%s">Peer Review</a>') % req.href.peerreviewmain()) 94 94 95 95 # IPermissionRequestor methods 96 96 … … 128 128 129 129 130 130 def match_request(self, req): 131 return req.path_info == '/peer ReviewMain' or req.path_info == "/preview_render"131 return req.path_info == '/peerreviewmain' or req.path_info == "/preview_render" 132 132 133 133 def process_request(self, req): 134 134 req.perm.require('CODE_REVIEW_DEV')
Attachments (0)
Note: See
TracTickets for help on using
tickets.
Glad to hear that fixed your problem. Not sure if you may run into other problems though because mixed case is sprinkled all over the source.
Anyway in the long run the names will become all lower case. That's on the Todo list.
Keeping this ticket open as a reminder.