Modify

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#13049 closed enhancement (fixed)

IE 8 doesn't support Array.prototype.forEach

Reported by: Peter Suter Owned by: Jun Omae
Priority: normal Component: WikiAutoCompletePlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

From comment:3:ticket:13012:

I'm using this plugin with the following patch on my production environments.

IE 8 doesn't support Array.prototype.forEach, which is used by jquery.textcomplete.js. In my production environments, javascript errors are captured and reported using windows.onerror. The patch would prevent noisy errors about forEach.

  • wikiautocomplete/htdocs/js/wikiautocomplete.js

    diff --git a/wikiautocomplete/htdocs/js/wikiautocomplete.js b/wikiautocomplete/htdocs/
    index ea6c607..4c966c1 100644
    a b  
    11jQuery(document).ready(function($) {
     2    if (Array.prototype.forEach === undefined)
     3        return;
     4
    25    var cache = {};
    36
    47    function escape_newvalue(value) {

Attachments (0)

Change History (3)

comment:1 Changed 5 weeks ago by Peter Suter

The proposed patch is fine with me. Feel free to commit.

comment:2 Changed 5 weeks ago by Jun Omae

Resolution: fixed
Status: newclosed

In 16185:

WikiAutoCompletePlugin: disable browsers which don't support Array.prototype.forEach (closes #13049)

comment:3 Changed 5 weeks ago by Jun Omae

Owner: changed from Peter Suter to Jun Omae

Thanks.

Modify Ticket

Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.