Install WikiAutoCompletePlugin to trac-hacks.org

[Ryan J Ollos]

The WikiAutoCompletePlugin looks very useful, and there's been a lot of development activity, so I was considering installing it to trac-hacks.org. Thoughts?

[Peter Suter]

That sounds nice.

I wonder if it would noticeably impact server performance due to the additional requests. You might want to keep an eye on that. Jun added some caching strategies in #12954.

I've been using this daily for two years without problems, but only on a Trac installation with few users.

[Jun Omae]

Fine by me. I'm using this plugin with the following patch on my production environments.

IE 8 doesn't support Array.prototype.forEach, which is used by jquery.textcomplete.js. In my production environments, javascript errors are captured and reported using windows.onerror. The patch would prevent noisy errors about forEach.

wikiautocomplete/htdocs/js/wikiautocomplete.js

@@ -1 +1 @@
 jQuery(document).ready(function($) {
+    if (Array.prototype.forEach === undefined)
+        return;
+
     var cache = {};
 
     function escape_newvalue(value) {

[Ryan J Ollos]

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

[Ryan J Ollos]

Installed and seems to be working well.

[Jun Omae]

Replying to rjollos:

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

[Peter Suter]

Replying to jun66j5:

Replying to rjollos:

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

#13049