Modify

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#13012 closed defect (fixed)

Install WikiAutoCompletePlugin to trac-hacks.org

Reported by: Ryan J Ollos Owned by: Ryan J Ollos
Priority: normal Component: TracHacks
Severity: normal Keywords:
Cc: Steffen Hoffmann, Ryan J Ollos, Jun Omae, Peter Suter Trac Release:

Description

The WikiAutoCompletePlugin looks very useful, and there's been a lot of development activity, so I was considering installing it to trac-hacks.org. Thoughts?

Attachments (0)

Change History (7)

comment:1 Changed 11 months ago by Ryan J Ollos

Owner: changed from Michael Renzmann to Ryan J Ollos
Status: newassigned

comment:2 Changed 11 months ago by Peter Suter

That sounds nice.

I wonder if it would noticeably impact server performance due to the additional requests. You might want to keep an eye on that. Jun added some caching strategies in #12954.

I've been using this daily for two years without problems, but only on a Trac installation with few users.

Last edited 11 months ago by Peter Suter (previous) (diff)

comment:3 Changed 11 months ago by Jun Omae

Fine by me. I'm using this plugin with the following patch on my production environments.

IE 8 doesn't support Array.prototype.forEach, which is used by jquery.textcomplete.js. In my production environments, javascript errors are captured and reported using windows.onerror. The patch would prevent noisy errors about forEach.

  • wikiautocomplete/htdocs/js/wikiautocomplete.js

    diff --git a/wikiautocomplete/htdocs/js/wikiautocomplete.js b/wikiautocomplete/htdocs/
    index ea6c607..4c966c1 100644
    a b  
    11jQuery(document).ready(function($) {
     2    if (Array.prototype.forEach === undefined)
     3        return;
     4
    25    var cache = {};
    36
    47    function escape_newvalue(value) {

comment:4 in reply to:  3 ; Changed 10 months ago by Ryan J Ollos

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

comment:5 Changed 10 months ago by Ryan J Ollos

Resolution: fixed
Status: assignedclosed

Installed and seems to be working well.

comment:6 in reply to:  4 ; Changed 10 months ago by Jun Omae

Replying to rjollos:

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

comment:7 in reply to:  6 Changed 10 months ago by Peter Suter

Replying to jun66j5:

Replying to rjollos:

Replying to jun66j5:

Fine by me. I'm using this plugin with the following patch on my production environments.

Is there any downside to committing that patch to the WikiAutoCompletePlugin repository?

No harm to commit. Also, that works fine on my environment.

#13049

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.