Modify

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#13068 closed enhancement (fixed)

Autocomplete in change information on wiki edit page

Reported by: Ryan J Ollos Owned by: Peter Suter
Priority: normal Component: WikiAutoCompletePlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

In wiki page Change information, it would be useful to autocomplete text in the Comment about this change text box. It accepts wiki formatting

Attachments (1)

T13068_complete_input_fields.diff (1.1 KB) - added by Peter Suter 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Ryan J Ollos

I haven't spent much time looking at the source for this plugin, but was wondering if you have any thoughts about eventually integrating this into Trac. If the plugin get a good amount of testing through use on this site and the edge cases get worked out, do you have an opinion on whether it would be a good fit and how much effort might be required to move it to Trac?

comment:2 Changed 7 years ago by Peter Suter

The plugin currently enables completions only for HTML elements matching $('textarea.wikitext'). But it looks like jquery-textcomplete added support for input[type=text] elements, so enabling that seems possible.

However we would probably still only want to enable it for fields that actually support wikitext, so using something like input[type=text].wikitext would be nice. But Trac does apparently no use the .wikitext class for any <input> elements, even when they do support wikitext like here.

comment:3 Changed 7 years ago by Ryan J Ollos

Okay, if you think it would work best to add wikitext or another specific class to the elements, I can investigate implementing that for Trac 1.2.1.

comment:4 in reply to:  1 Changed 7 years ago by Peter Suter

Replying to Ryan J Ollos:

any thoughts about eventually integrating this into Trac

I created #13071 to discuss this separately.

Changed 7 years ago by Peter Suter

comment:5 in reply to:  3 Changed 7 years ago by Peter Suter

Okay, if you think it would work best to add wikitext or another specific class to the elements, I can investigate implementing that for Trac 1.2.1.

Sounds great. This patch would enable the autocompletions (but doesn't until wikitext class is added on relevant <input> elements).

Removing .wikitext from the last line in the patch enables autocompletions for all input fields (including non-wikitext fields like "Email:", "Max items per page" etc. and we definitely don't want that).

comment:6 Changed 7 years ago by Ryan J Ollos

Thanks, the patch works well. I created trac:#12701 for adding the wikitext class to input text fields that accept wiki markup.

comment:7 Changed 7 years ago by Peter Suter

In 16269:

WikiAutoCompletePlugin: Also autocomplete <input type="text"> fields.
(see #13068)

comment:8 Changed 7 years ago by Peter Suter

Resolution: fixed
Status: newclosed

comment:9 Changed 6 years ago by anonymous

I think this causes confusing double popups: #13498

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Peter Suter.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.