Modify

Opened 7 years ago

Closed 7 years ago

#13075 closed enhancement (fixed)

Tweak color

Reported by: Peter Suter Owned by: Peter Suter
Priority: normal Component: WikiAutoCompletePlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

From comment:5:ticket:13071:

The current blue color rgb(110, 183, 219); is getting overbearing to users who are making edits to wiki pages a lot. It gives the appearance of dark areas flashing on your screen. Neither is this color used anywhere else in Trac.

The suggestion is therefore to use already existing colors, for example the same as for table class changes:

color: #663;
border: 1px solid;
border-color: #eea #dd9 #dd9 #eea;
background: #ffd;

Attachments (2)

T13075_old_blue_new_yellow.png (10.4 KB) - added by Peter Suter 7 years ago.
T13075_other_dropdowns.png (17.1 KB) - added by Peter Suter 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Peter Suter

comment:1 Changed 7 years ago by Peter Suter

I assume you mean something like this:

  • wikiautocomplete/htdocs/css/jquery.textcomplete.css

    # HG changeset patch
    # User Peter Suter <petsuter@gmail.com>
    # Date 1487497209 -3600
    #      Sun Feb 19 10:40:09 2017 +0100
    # Node ID 52f959b9043ee2aa65c9865eabb22bfee37e885b
    # Parent  45332d7e6a5da48eb5563a3bc3b0cd557a6873f9
    WikiAutoCompletePlugin: Change color of selection from blue to yellow.
    (see #13075)
    
    diff -r 45332d7e6a5d -r 52f959b9043e wikiautocomplete/htdocs/css/jquery.textcomplete.css
    a b  
    1919
    2020.dropdown-menu li:hover,
    2121.dropdown-menu .active {
    22     background-color: rgb(110, 183, 219);
     22    background: #ffd;
     23    color: #663;
    2324}
    2425
    2526.wikiautocomplete-menu-descr { color: #777; margin-left: 1.2em }

(I omitted the border. It seemed unneeded and a bit distracting.)

These (old and new) colors look like this:

I like it. Is that what you had in mind? Other opinions?

Last edited 7 years ago by Peter Suter (previous) (diff)

Changed 7 years ago by Peter Suter

Attachment: T13075_other_dropdowns.png added

comment:2 Changed 7 years ago by Peter Suter

Neither is this color used anywhere else in Trac.

Well, it's (similar to) the color used in most other dropdowns:

Only the keywords suggestions (KeywordSuggestPlugin?) here seem to use a similar yellow color.

comment:3 Changed 7 years ago by figaro

Correct.

The issue occurs most notably when editing an Image-processor.

comment:4 Changed 7 years ago by Peter Suter

In 16268:

WikiAutoCompletePlugin: Change color of selection from blue to yellow.
(see #13075)

comment:5 Changed 7 years ago by Peter Suter

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Peter Suter.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.