Should pass as parameter rather than string interpolation for logging api

[Jun Omae]

For logging api, this plugin use string interpolation. I think we should pass as parameter like this:

advancedworkflow/controller.py

@@ -127 +127 @@
     def _new_owner(self, ticket):
         """Determines the new owner"""
         component = model.Component(self.env, name=ticket['component'])
-        self.env.log.debug("component %s, owner %s" % (component, component.owner))
+        self.log.debug("component %s, owner %s", component, component.owner)
         return component.owner
 
 
@@ -318 +318 @@
                 script += extension
                 break
         else:
-            self.env.log.error("Error in ticket workflow config; could not find external command to run for %s in %s" % (action, os
+            self.log.error("Error in ticket workflow config; could not find "
+                           "external command to run for %s in %s",
+                           action, os.path.join(self.env.path, 'hooks'))
             return
         retval = call([script, str(ticket.id), req.authname])
         if retval:
-            self.env.log.error("External script %r exited with return code %s." % (script, retval))
+            self.log.error("External script %r exited with return code %s.",
+                           script, retval)
 
 
 class TicketWorkflowOpTriage(TicketWorkflowOpBase):
@@ -371 +374 @@
             if value == ticket[field].strip():
                 break
         else:
-            self.env.log.error("Bad configuration for 'triage' operation in action '%s'" % action)
+            self.log.error("Bad configuration for 'triage' operation in "
+                           "action '%s'", action)
             status = 'new'
         return status
 
@@ -467 +471 @@
             tn.notify(xticket, newticket=False, modtime=now)
         except Exception, e:
             self.log.exception("Failure sending notification on change to "
-                               "ticket #%s: %s" % (ticketnum, e))
+                               "ticket #%s: %s", ticketnum, e)
 
 
 class TicketWorkflowOpResetMilestone(TicketWorkflowOpBase):

[Ryan J Ollos]

This was already fixed for the 1.2 branch in r14247. Feel free to commit changes to the other branches if you like.

[Jun Omae]

In 16305:

AdvancedTicketWorkflowPlugin/0.12: pass as parameter rather than string interpolation for logging api (closes #13103)