Modify

Opened 4 months ago

Closed 4 months ago

#13193 closed defect (fixed)

Plugin does not work with trac 1.2

Reported by: dornheim@… Owned by: Ryan J Ollos
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.2

Description (last modified by Ryan J Ollos)

Hi,

i think this plugin is not compatible with trac v1.2.

After installing i get some errors:

Trac[loader] ERROR: Skipping "codereview = codereview":
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/trac/loader.py", line 68, in _load_eggs
    entry.load(require=True)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2229, in load
    return self.resolve()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2235, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python2.7/dist-packages/codereview/__init__.py", line 10, in <module>
    import peerReviewMain
  File "/usr/local/lib/python2.7/dist-packages/codereview/peerReviewMain.py", line 21, in <module>
    from trac.util.text import _
ImportError: cannot import name _

So i patched all from trac.util.text import _ to from trac.util.translation import _

Then it is possible to activate the PlugIn, but if i select "PerrReview" i get an error that macros.html was not found.

Will this be fixed?

Attachments (0)

Change History (6)

comment:1 Changed 4 months ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 4 months ago by Ryan J Ollos

Description: modified (diff)

comment:3 Changed 4 months ago by Ryan J Ollos

Owner: changed from Cinc-th to Ryan J Ollos
Status: newaccepted

comment:4 Changed 4 months ago by Ryan J Ollos

In 16616:

TracCodeReview 3.1: Fix incorrect imports

Refs #13193.

comment:5 Changed 4 months ago by Ryan J Ollos

Please try with r16616.

comment:6 Changed 4 months ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

In 16617:

TracCodeReview 3.1: Replace deprecated add_javascript with add_script

Fixes #13193.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.