FlexibleAssignToPlugin not compatible with Trac 1.2

[Jon Ashley]

FlexibleAssignToPlugin won't work with Trac 1.2, because the tuple _TRUE_VALUES has been removed from trac/config.py.

A simple fix is to declare a replacement for _TRUE_VALUES in the plugin itself.

[Ryan J Ollos]

In 16702:

FlexibleAssignTo 0.8.13: Replace us of deprecated _TRUE_VALUES

Refs #13233.

[Ryan J Ollos]

r16702 is untested. Please let me know if the change works for you.

[Ryan J Ollos]

In 16704:

FlexibleAssignTo 0.8.13: Conform to PEP8

Refs #13233.

[Jon Ashley]

Two review comments:

• The function getbool() in flexibleassignto.py is now unused so should be deleted.
• The __init__.py file needs to contain the statement

  from flexibleassignto import *
  

  or similar, otherwise the user-provided implementation of IValidOwnerProvider cannot load.

[Ryan J Ollos]

Replying to Jon Ashley:

• The function getbool() in flexibleassignto.py is now unused so should be deleted.

I realized it wasn't used but left it because removing it could break someone's IValidOwnerProvider implementation if they are using the function.

• The __init__.py file needs to contain the statement

  from flexibleassignto import *
  

  or similar, otherwise the user-provided implementation of IValidOwnerProvider cannot load.

I expected that a user would create a single-file plugin that uses the API rather than adding their code to this plugin and recompiling the egg/wheel. No problem to add it back, I suppose.

[Jon Ashley]

Replying to Ryan J Ollos:

I expected that a user would create a single-file plugin that uses the API rather than adding their code to this plugin and recompiling the egg/wheel. No problem to add it back, I suppose.

The way the plugin is used at my site is that the egg file is compiled from the plugin and placed in the Trac environment's plugin folder, then the LocalValidOwnerProvider.py file is also placed in the Trac environment's plugin folder. It's not managed as part of the plugin and doesn't end up in the egg file.

That sounds like the situation you are expecting, but that's what isn't working unless the IValidOwnerProvider name is exported in the __init__.py file.

[Ryan J Ollos]

Replying to Jon Ashley:

That sounds like the situation you are expecting, but that's what isn't working unless the IValidOwnerProvider name is exported in the __init__.py file.

Yes, I see. Generally the * import isn't needed in __init__.py if you modify the entry point appropriately, but in this case if you expect to do flexibleassignto import IValidOwnerProvider rather than flexibleassignto.flexibleassignto import IValidOwnerProvider, the * import is needed.

[Ryan J Ollos]

In 16706:

FlexibleAssignTo 0.8.13: Fix export of interface and cleanup setup.py

Refs #13233.

[Jon Ashley]

This now works for me. I hadn't considered that other users of the plugin might be relying on getbool().

[Ryan J Ollos]

Replying to Jon Ashley:

This now works for me.

Thanks for the feedback!

I hadn't considered that other users of the plugin might be relying on getbool().

I doubt it will affect anyone either way, but I considered it was just easier to be on the safe side of things.