Modify

Opened 5 years ago

Closed 18 months ago

#13263 closed defect (fixed)

Notification doesn't work

Reported by: tim.ward@… Owned by: osimons
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords: Notification
Cc: Olemis Lang Trac Release: 1.2

Description (last modified by Ryan J Ollos)

When setting notify=True on the ticket.update call the INotificationSubscriber plugins don't appear to get called.

It looks like notify=True results in calling some old, outdated, Trac notification system which works off some hard-coded stuff in trac.ini, rather than the current notification system which is configurable by user preferences.

So if you're using the new user-configurable notification system all you get if you set notify=True for ticket.update is

Trac[compat] INFO: no recipient for a ticket notification

in the log, and no emails.

Attachments (0)

Change History (6)

comment:1 Changed 5 years ago by anonymous

What seems to work is, in ticket.py change

                tn = TicketNotifyEmail(self.env)
                tn.notify(t, newticket=False, modtime=when)

to

                event = TicketChangeEvent( 'changed', t, when, author, comment )
                NotificationSystem( self.env ).notify( event )

I haven't attempted to do the same for create (I've only tried it for update) and I haven't looked at whether there are any unit tests covering this area.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:2 Changed 5 years ago by Ryan J Ollos

Description: modified (diff)

comment:3 Changed 5 years ago by Ryan J Ollos

comment:4 Changed 5 years ago by Ryan J Ollos

If you can provide a patch, please see trac:PatchWelcome.

comment:5 Changed 4 years ago by anonymous

As a workaround, adding the old config parameters in trac.ini seems to "fix" this issue as well...

So adding these "back" in notification-section in trac.ini worked for us:

always_notify_reporter=true
always_notify_owner=true

So the old to-be-deprecated code seems to be still using those flags...

Last edited 4 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 18 months ago by Jun Omae

Resolution: fixed
Status: newclosed

Fixed in [18219].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.